-
Notifications
You must be signed in to change notification settings - Fork 479
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add feature ablation to Insights #319
Conversation
edward-io
commented
Mar 10, 2020
•
edited
Loading
edited
- add feature ablation option
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
c695721
to
e459749
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for adding this, looks good! I think it might be good to also add the perturbations_per_eval argument as a NumberConfig for FeatureAblation, since it very substantially affects performance, and we can often set it to a higher value depending on memory available.
e459749
to
03601d8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
03601d8
to
9f92429
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
9f92429
to
a1967cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@edward-io has imported this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
a1967cb
to
b169a4f
Compare
@edward-io merged this pull request in 8312e68. |
Summary: - add feature ablation option Pull Request resolved: pytorch#319 Reviewed By: orionr Differential Revision: D20371928 Pulled By: edward-io fbshipit-source-id: ea558b14c5fcfc754ea4be4de295433965e7f1f9