Fixing CUDA delta issue #169
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NarineK
reviewed
Nov 11, 2019
| attributions_orig = attr_orig.attribute(**kwargs) | ||
| if attr_orig.has_convergence_delta(): | ||
| attributions_orig = attr_orig.attribute( | ||
| return_convergence_delta=True, **kwargs |
There was a problem hiding this comment.
Looks great! Do we want to return attributions_orig, delta = here ?
NarineK
reviewed
Nov 11, 2019
tests/attr/test_data_parallel.py
Outdated
| if batch_size: | ||
| attributions_dp = attr_dp.attribute( | ||
| internal_batch_size=batch_size, **kwargs | ||
| ) | ||
| else: | ||
| attributions_dp = attr_dp.attribute(**kwargs) | ||
| if attr_orig.has_convergence_delta(): | ||
| attributions_dp = attr_dp.attribute( |
There was a problem hiding this comment.
nit: also here: attributions_dp, delta ?
|
Thanks, good point, updated! |
NarineK
approved these changes
Nov 12, 2019
There was a problem hiding this comment.
@vivekmig is landing this pull request. If you are a Facebook employee, you can view this diff on Phabricator.
miguelmartin75
pushed a commit
to miguelmartin75/captum
that referenced
this pull request
Nov 20, 2019
Summary: Convergence delta was failing on GPUs since the total attribution tensor was not being created on the same device, this fixes that bug. Also, adds data parallel / CUDA tests for computing deltas whenever available. Issue: pytorch#163 Pull Request resolved: pytorch#169 Differential Revision: D18440711 Pulled By: vivekmig fbshipit-source-id: 5b67ba75492eb3c6933d13e1e67914bf1d3e5241
miguelmartin75
pushed a commit
to miguelmartin75/captum
that referenced
this pull request
Dec 20, 2019
Summary: Convergence delta was failing on GPUs since the total attribution tensor was not being created on the same device, this fixes that bug. Also, adds data parallel / CUDA tests for computing deltas whenever available. Issue: pytorch#163 Pull Request resolved: pytorch#169 Differential Revision: D18440711 Pulled By: vivekmig fbshipit-source-id: 5b67ba75492eb3c6933d13e1e67914bf1d3e5241
miguelmartin75
pushed a commit
to miguelmartin75/captum
that referenced
this pull request
Dec 20, 2019
Summary: Convergence delta was failing on GPUs since the total attribution tensor was not being created on the same device, this fixes that bug. Also, adds data parallel / CUDA tests for computing deltas whenever available. Issue: pytorch#163 Pull Request resolved: pytorch#169 Differential Revision: D18440711 Pulled By: vivekmig fbshipit-source-id: 5b67ba75492eb3c6933d13e1e67914bf1d3e5241
NarineK
pushed a commit
to NarineK/captum-1
that referenced
this pull request
Nov 19, 2020
Summary: Convergence delta was failing on GPUs since the total attribution tensor was not being created on the same device, this fixes that bug. Also, adds data parallel / CUDA tests for computing deltas whenever available. Issue: pytorch#163 Pull Request resolved: pytorch#169 Differential Revision: D18440711 Pulled By: vivekmig fbshipit-source-id: 5b67ba75492eb3c6933d13e1e67914bf1d3e5241
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Convergence delta was failing on GPUs since the total attribution tensor was not being created on the same device, this fixes that bug. Also, adds data parallel / CUDA tests for computing deltas whenever available.
Issue: #163