Add support for nested progressbar to tracincp even when tqdm is not available. #1046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Summary: In SimpleProgress add support for context methods (__enter__, __exit__). For simple progress bar it means the parent(context) progress bar is shown once each time its value change. Test Plan: Unit tests. python -m unittest -v tests.utils.test_progress Reviewers: Subscribers: Tasks: Tags:
Summary: NullProgress implements the Progress API, but has no output. It can be used to simplify code showing no progress. Test Plan: python -m unittest -v tests.utils.test_progress Reviewers: Subscribers: Tasks: Tags:
Summary: Add support for nested progress bars for tracincp including support without `tqdm`. Test Plan: python -m unittest -v tests.influence._core.test_tracin_show_progress.TestTracInShowProgress.test_tracin_show_progress_TracInCPFast_self_influence_by_checkpoints Reviewers: Subscribers: Tasks: Tags:
Summary: use only one `or` for multiple types Pull Request resolved: pytorch#1034 Reviewed By: vivekmig Differential Revision: D40030553 Pulled By: aobo-y fbshipit-source-id: 4fec520d82e3b7c200f6fdc50fd66e8ae71da8c1
Summary: - Require successful sphinx build in CI. Previously sphinx build will always pass even with errors (example below)  - Fixed the remaining sphinx errors: - remove `pytext.rst`. We never really make pytext model public and its doc cannot be built due to missing pytext package (which is deprecated now); we can later migrate to torchtext and re-opensource it if needed - remove `approximation_methods.rst` which is not public - other trivial format issues Pull Request resolved: pytorch#1033 Reviewed By: vivekmig Differential Revision: D39721114 Pulled By: aobo-y fbshipit-source-id: e0a9af1975f6bf29fb4b8ca394f028325afb5f49
Summary: Fixes formatting issues according to Flake8 Test Plan: flake8 . Produces no output. Reviewers: Subscribers: Tasks: Tags:
Summary: Fix some typing issues on progressbar work. Test Plan: ./scripts/run_mypy.sh Reviewers: Subscribers: Tasks: Tags:
Summary: - Require successful sphinx build in CI. Previously sphinx build will always pass even with errors (example below)  - Fixed the remaining sphinx errors: - remove `pytext.rst`. We never really make pytext model public and its doc cannot be built due to missing pytext package (which is deprecated now); we can later migrate to torchtext and re-opensource it if needed - remove `approximation_methods.rst` which is not public - other trivial format issues Pull Request resolved: pytorch#1033 Reviewed By: vivekmig Differential Revision: D39721114 Pulled By: aobo-y fbshipit-source-id: e0a9af1975f6bf29fb4b8ca394f028325afb5f49
Summary: Ufmt applied. Test Plan: ufmt check . Reviewers: Subscribers: Tasks: Tags:
|
@cyrjano has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Summary: Test Plan: Reviewers: Subscribers: Tasks: Tags:
|
@cyrjano has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This Pull request add support for nested progressbar in SimpleProgress bar (i.e. when tqdm is not installed) by leveraging Python contexts (with statements) that is also implemented in tqdm. To keep
SimpleProgresssimple this is the behaviour:This support is used now in TracInCp and TracInCpFast methods.
