Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix visualization when greyscale image as input to ImageFeature class #1044

Open
wants to merge 11 commits into
base: master
Choose a base branch
from

Conversation

Infinity-ops
Copy link

ISSUE:: When the CIFAR10/FashionMNIST greyscale images are used as the input to ImageFeature, using "from captum.insights import AttributionVisualizer" produces ==> Runtime Error: Number of Dims in Permute Does Not Match

FIX:: Existing feature.py accepts only RGB images as input, when greyscale images is passed as input to the captum insights visualizer, it raises the Runtime Error. It fixed by removing the permute operation based on the input image format.

FIX:: using "from captum.insights import AttributionVisualizer"  for the CIFAR10/FashionMNIST in greyscale as the input via ImageFeature produces ==> RuntimeError: number of dims don't match in permute
@Infinity-ops Infinity-ops changed the title 🐛 Update features.py 🐛 Fix visualization for greyscale image in ImageFeature class Oct 11, 2022
@Infinity-ops Infinity-ops changed the title 🐛 Fix visualization for greyscale image in ImageFeature class 🐛 Fix visualization when greyscale image as input to ImageFeature class Oct 11, 2022
@facebook-github-bot
Copy link
Contributor

Hi @Infinity-ops!

Thank you for your pull request and welcome to our community.

Action Required

In order to merge any pull request (code, docs, etc.), we require contributors to sign our Contributor License Agreement, and we don't seem to have one on file for you.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@fb.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

[SOLUTION] The fix is explained here : https://discuss.circleci.com/t/build-fails-on-apt-get-update/38015 
Apt-get update appears to fail the first time it is run. Therefore, its ought to run it again by replacing
 "sudo apt-get update" with "(sudo apt-get update || sudo apt-get update)" to fix your configuration file.

Secondly, as --force-yes parameter is deprecated , replaced with --allow instead in the cuda apt installation command.
@Infinity-ops Infinity-ops changed the title 🐛 Fix visualization when greyscale image as input to ImageFeature class Fix visualization when greyscale image as input to ImageFeature class Oct 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants