Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mask for Adversarial Attacks #1043

Closed
wants to merge 7 commits into from
Closed

Mask for Adversarial Attacks #1043

wants to merge 7 commits into from

Conversation

jgonik
Copy link
Contributor

@jgonik jgonik commented Oct 11, 2022

Adds an optional mask argument to the FGSM and PGD adversarial attacks. This mask determines which pixels are affected by the adversarial perturbations. If no mask is specified, then all pixels are affected. This PR resolves #941.

Copy link
Contributor

@vivekmig vivekmig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks for the great work on this @jgonik as well as the thorough test cases!

There do seem to be some minor mypy failures in the CircleCI test results, can you look into resolving those? You can also run these locally using scripts/run_mypy.sh

captum/robust/_core/fgsm.py Outdated Show resolved Hide resolved
captum/robust/_core/pgd.py Show resolved Hide resolved
captum/robust/_core/fgsm.py Outdated Show resolved Hide resolved
@vivekmig
Copy link
Contributor

Looks great, thanks! You can import this diff now, looks ready to merge.

@facebook-github-bot
Copy link
Contributor

@jgonik has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator.

@facebook-github-bot
Copy link
Contributor

Hi @jgonik!

Thank you for your pull request.

We require contributors to sign our Contributor License Agreement, and yours needs attention.

You currently have a record in our system, but the CLA is no longer valid, and will need to be resubmitted.

Process

In order for us to review and merge your suggested changes, please sign at https://code.facebook.com/cla. If you are contributing on behalf of someone else (eg your employer), the individual CLA may not be sufficient and your employer may need to sign the corporate CLA.

Once the CLA is signed, our tooling will perform checks and validations. Afterwards, the pull request will be tagged with CLA signed. The tagging process may take up to 1 hour after signing. Please give it that time before contacting us about it.

If you have received this in error or have any questions, please contact us at cla@meta.com. Thanks!

@facebook-github-bot
Copy link
Contributor

Thank you for signing our Contributor License Agreement. We can now accept your code for this (and any) Meta Open Source project. Thanks!

@facebook-github-bot
Copy link
Contributor

@vivekmig merged this pull request in a1007a8.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Mask for Adversarial Attacks
3 participants