Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set release version and base PyTorch version for 1.11 pytorch release #2210

Merged
merged 1 commit into from
Feb 10, 2022
Merged

Set release version and base PyTorch version for 1.11 pytorch release #2210

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 8 additions & 8 deletions .circleci/config.yml
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

16 changes: 8 additions & 8 deletions .circleci/config.yml.in
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,12 +32,8 @@ commands:
- run:
name: adding UPLOAD_CHANNEL to BASH_ENV
command: |
our_upload_channel=nightly
# On tags upload to test instead
if [[ -n "${CIRCLE_TAG}" ]] || [[ ${CIRCLE_BRANCH} =~ release/* ]]; then
our_upload_channel=test
fi
echo "export UPLOAD_CHANNEL=${our_upload_channel}" >> ${BASH_ENV}
# Hardcoded for release branch
echo "export UPLOAD_CHANNEL=test" >> ${BASH_ENV}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since we on the release branch, why is this change required ? It should automatically use test, correct ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

According to @mthrok : Even though UPLOAD_CHANNEL is set to test if the branch name is release/*, when you are making a PR against the release branch, the value of CIRCLE_BRANCH is something like pr/XXX, and the CI jobs of PRs against release branches use nightly builds.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's correct. We need this for invoking signal for CI like. CicleCI's spec could have changed but it's safe to hard code this.

#1690

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Got it! Thanks for explanation.

load_conda_channel_flags:
description: "Determines whether we need extra conda channels"
steps:
Expand All @@ -60,11 +56,11 @@ binary_common: &binary_common
build_version:
description: "version number of release binary; by default, build a nightly"
type: string
default: ""
default: "0.11.0"
pytorch_version:
description: "PyTorch version to build against; by default, use a nightly"
type: string
default: ""
default: "1.11.0"
# Don't edit these
python_version:
description: "Python version to build against (e.g., 3.8)"
Expand Down Expand Up @@ -158,6 +154,7 @@ jobs:
resource_class: 2xlarge+
steps:
- checkout
- designate_upload_channel
- attach_workspace:
at: third_party
- run:
Expand Down Expand Up @@ -200,6 +197,7 @@ jobs:
xcode: "12.0"
steps:
- checkout
- designate_upload_channel
- load_conda_channel_flags
- attach_workspace:
at: third_party
Expand Down Expand Up @@ -252,6 +250,7 @@ jobs:
name: windows-cpu
steps:
- checkout
- designate_upload_channel
- load_conda_channel_flags
- windows_install_cuda
- run:
Expand Down Expand Up @@ -648,6 +647,7 @@ jobs:
- attach_workspace:
at: ~/workspace
- checkout
- designate_upload_channel
- load_conda_channel_flags
- run:
name: Install packages
Expand Down