Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fill value for non-tensor inputs during shape prop #933

Merged
merged 1 commit into from
Jan 26, 2024
Merged

Fill value for non-tensor inputs during shape prop #933

merged 1 commit into from
Jan 26, 2024

Conversation

kwen2501
Copy link
Contributor

Fixes #932

H-Huang
H-Huang approved these changes Jan 26, 2024
View reviewed changes
Copy link
Member

@H-Huang H-Huang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kwen2501 kwen2501 merged commit 3632106 into main Jan 26, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@H-Huang H-Huang H-Huang approved these changes

@tugsbayasgalan tugsbayasgalan Awaiting requested review from tugsbayasgalan

@angelayi angelayi Awaiting requested review from angelayi

Assignees
No one assigned
Labels
cla signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Shape prop error when kwargs have constants
3 participants
@kwen2501 @H-Huang @facebook-github-bot