Re-support kwargs at run time #929
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angelayi
approved these changes
Jan 19, 2024
pippy/IR.py
Outdated
| # To prevent conflicts with field names, the method and attribute names | ||
| # start with an underscore | ||
| submod0.graph._codegen.pytree_info = ( | ||
| submod0.graph._codegen.pytree_info._replace(out_spec=None) |
There was a problem hiding this comment.
why do you want to set it to be None? Then the output structure will not match the eager module -- but not sure if you care about this.
There was a problem hiding this comment.
Because the original program's output format should be applied to the last stage, not stage 0 :)
…args as full model
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Implements #928
Users want the first pipeline stage to accept kwargs if the original program does.
This is controlled by the
_codegenfield of the graph as @angelayi suggests, so we make a copy from the traced program to submod0.Feature/Issue validation/testing
Added kwargs in test_fwd.py.
Also changed a few HF examples to directly kwargs.