Add docs for torch.chain_matmul, torch.qr, torch.range, torch.cholesky #59
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
facebook-github-bot
added
the
CLA Signed
svekars
reviewed
Jun 5, 2024
kit1980
requested changes
Jun 7, 2024
README.md
Outdated
| The function `torch.range()` is deprecated as its usage is incompatible with Python's builtin range. Instead, use `torch.arange()` as it produces values in `[start, end)`. | ||
|
|
||
| Migration guide: | ||
| * The usage of `torch.range(a, b)` should be replaced with `torch.arange(a, b)`. |
There was a problem hiding this comment.
This is not correct, upper bound needs to be changed.
There was a problem hiding this comment.
Addressed changes in 34f8af9
README.md
Outdated
| This function is deprecated in favor of `torch.linalg.multi_dot`. | ||
|
|
||
| Migration guide: | ||
| `multi_dot` accepts a list of two or more tensors whereas `chain_multimul` accepted multiple tensors as input arguments. For migration, convert the multiple tensors in argument of `chain_multimul` into a list of two or more tensors for `multi_dot`. |
There was a problem hiding this comment.
This talks about chain_multimul, not chain_matmul
There was a problem hiding this comment.
Addresses changes in 34f8af9
kit1980
approved these changes
Jun 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Partially addresses #56
Added
TOR101deprecation doc fortorch.cholesky,torch.chain_matmul,torch.qr,torch.range.