Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for specifing an explicit GSSAPI mech #19

Closed
wants to merge 1 commit into from

Conversation

optiz0r
Copy link
Contributor

@optiz0r optiz0r commented Jul 12, 2019

Add support for passing an explicit mech through to gssapi's
SecurityContext constructor. This allows overriding the auto-detected
mechanism, and enabling support for RFC4178 SPNEGO.

Fixes #18

@PeteW
Copy link

PeteW commented Jul 22, 2019

Looking forward to seeing this support added as we are coming from the same common need.

@cap1tan
Copy link

cap1tan commented Sep 13, 2019

Have been scratching my head wondering why authentication was failing but this solved my issue! Thank you!

@simo5
Copy link

simo5 commented Sep 13, 2019

@frozencemetery this sounds reasonable to me

@frozencemetery
Copy link
Member

@simo5 Have you changed your mind from your comment on #18 (comment) then?

@optiz0r
Copy link
Contributor Author

optiz0r commented Nov 15, 2019

Even if the go library is poor, this pull request is just to add some more flexibility into the requests-gssapi library that might be useful for other purposes and can be ignored in most cases where not needed. It would be useful to have this merged/released anyway.

@simo5
Copy link

simo5 commented Nov 18, 2019

@simo5 Have you changed your mind from your comment on #18 (comment) then?

Btw, no I have not changed idea, but allowing to specify a mechanism is not endorsing another library, and has other uses, including testing that it can apply to, so I think this request is worth considering.
But you are the ultimate arbiter here.

@optiz0r
Copy link
Contributor Author

optiz0r commented Nov 18, 2019

I was doing some more work on this yesterday, and found a viable workaround which does not require this PR being merged, so I'll leave it up to you whether you want to merge or abandon. I'll post details on #18.

@frozencemetery
Copy link
Member

Alright. I'd misinterpreted your comment as an objection to this functionality.

I have no objection either. @optiz0r would you mind fixing the code to pass CI? Looks like flake errors.

@kamikaze
Copy link

kamikaze commented Dec 3, 2019

please

Add support for passing an explicit mech through to gssapi's
`SecurityContext` constructor. This allows overriding the auto-detected
mechanism, and enabling support for RFC4178 SPNEGO.

Fixes pythongssapi#18
@frozencemetery
Copy link
Member

Thanks for updating. Github doesn't notify me when you do that (though I think that might have finally changed). Working on this now.

@frozencemetery
Copy link
Member

Pushed to master as c9e429c

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support for explicit GSSAPI mech
6 participants