Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix invalid escape sequence "\s" #10

Conversation

stanislavlevin
Copy link
Contributor

To prevent interference of escaping in strings with escaping in regex
strings regex one should be marked as raw.

Resolves: #9

To prevent interference of escaping in strings with escaping in regex
strings regex one should be marked as raw.

Resolves: pythongssapi#9
@frozencemetery
Copy link
Member

Awesome, thanks @stanislavlevin! We inherited this code from requests-kerberos, so I'll pass it along to them as well.

One note before I merge: GitHub isn't associating this commit with your account. Typically, this is because whatever email you used isn't associated with your account. I'll wait a couple days in case you want to fix that and then merge.

Thanks again!

@stanislavlevin
Copy link
Contributor Author

Hello @frozencemetery !
Thank you for review!
I've changed my email to commit's one.
Hope this helps :-)

@frozencemetery frozencemetery merged commit a41831e into pythongssapi:master Jul 5, 2018
@stanislavlevin stanislavlevin deleted the fix_invalid_escape_sequence branch July 6, 2018 06:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants