Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set HOMEBREW_NO_INSTALL_CLEANUP to speedup brew installs #9713

Merged
merged 1 commit into from
Feb 11, 2023

Conversation

Avasam
Copy link
Sponsor Collaborator

@Avasam Avasam commented Feb 11, 2023

As the inline comment says: Speedup brew install. Environments are isolated, no need to cleanup old versions.
While working on a PR that touched pyaudio, I noticed this from runs like https://github.com/python/typeshed/actions/runs/4148676771/jobs/7176901691#step:5:54

I also moved the NONINTERACTIVE under env

@JelleZijlstra JelleZijlstra merged commit 2930f8c into python:main Feb 11, 2023
@JelleZijlstra
Copy link
Member

Thanks!

@Avasam Avasam deleted the HOMEBREW_NO_INSTALL_CLEANUP branch February 11, 2023 19:21
@AlexWaygood
Copy link
Member

AlexWaygood commented Feb 20, 2023

I don't know much about homebrew -- would it be worth adding the other two environment variables that were just added to CPython's workflow in https://github.com/python/cpython/pull/102074/files as well?

@Avasam
Copy link
Sponsor Collaborator Author

Avasam commented Feb 20, 2023

I don't know much about homebrew -- would it be worth adding the other two environment variables that were just added to CPython's workflow in python/cpython#102074 (files) as well?

Me neither, but here's the doc: https://docs.brew.sh/Manpage#environment
HOMEBREW_NO_AUTO_UPDATE definitely. For the same reasons we don't need to update pip in the CI
HOMEBREW_NO_ANALYTICS is up to you I guess. Analytics is good for the homebrew devs. I think it's more a matter of opting out of data collection than speeding up CI (although anything that speeds up CI isn't bad either): https://docs.brew.sh/Analytics#opting-out

@AlexWaygood
Copy link
Member

HOMEBREW_NO_ANALYTICS is up to you I guess. Analytics is good for the homebrew devs. I think it's more a matter of opting out of data collection than speeding up CI (although anything that speeds up CI isn't bad either): https://docs.brew.sh/Analytics#opting-out

Running stubtest on macOS in CI is consistently slowesr/more backed-up than the other two operating systems, so I'd be up for it tbh :p

@AlexWaygood
Copy link
Member

Also, same as CPython (python/cpython#102074 (comment)), we're probably somewhat atypical users of homebrew 😄

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants