Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use Final for Constant Literals in the stdlib #12332

Merged
merged 16 commits into from
Jul 15, 2024
Merged

Use Final for Constant Literals in the stdlib #12332

merged 16 commits into from
Jul 15, 2024

Conversation

max-muoto
Copy link
Contributor

@max-muoto max-muoto commented Jul 13, 2024 •
edited
Loading

Use Final for constant literals per this comment.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
@max-muoto max-muoto marked this pull request as ready for review July 13, 2024 17:39
AlexWaygood
AlexWaygood requested changes Jul 15, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Mostly looks great, but a few changes I suggest deferring to a followup:

stdlib/@tests/stubtest_allowlists/linux-py313.txt Show resolved Hide resolved
stdlib/_osx_support.pyi Outdated Show resolved Hide resolved
stdlib/_winapi.pyi Outdated Show resolved Hide resolved
stdlib/argparse.pyi Outdated Show resolved Hide resolved
stdlib/bdb.pyi Outdated Show resolved Hide resolved
stdlib/distutils/debug.pyi Outdated Show resolved Hide resolved
stdlib/multiprocessing/reduction.pyi Outdated Show resolved Hide resolved
stdlib/site.pyi Outdated Show resolved Hide resolved
@max-muoto
Copy link
Contributor Author

Thanks! Mostly looks great, but a few changes I suggest deferring to a followup:

Thanks! Sorry didn't mean to make some of those changes you saw.

@github-actions GitHub Actions

This comment has been minimized.

Sign in to view
AlexWaygood
AlexWaygood approved these changes Jul 15, 2024
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@github-actions GitHub Actions
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@AlexWaygood AlexWaygood changed the title Use Final for Constant Literals Use Final for Constant Literals in the stdlib Jul 15, 2024
@AlexWaygood AlexWaygood merged commit 0df6028 into python:main Jul 15, 2024
63 checks passed
max-muoto added a commit to max-muoto/typeshed that referenced this pull request Jul 23, 2024
@max-muoto @AlexWaygood
Use Final for Constant Literals in the stdlib (python#12332)
c93db65 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
max-muoto added a commit to max-muoto/typeshed that referenced this pull request Sep 8, 2024
@max-muoto @AlexWaygood
Use Final for Constant Literals in the stdlib (python#12332)
7ad4469 
Co-authored-by: Alex Waygood <Alex.Waygood@Gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@max-muoto @AlexWaygood