Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add MimeTypes.add_types method #12329

Merged
merged 5 commits into from
Jul 13, 2024
Merged

Conversation

Eclips4
Copy link
Member

@Eclips4 Eclips4 commented Jul 13, 2024

Somehow, it got lost when other methods were added 🙂

This comment has been minimized.

Copy link
Collaborator

@srittau srittau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: Could you move it between __init__ and guess_extension to match the implementation order? This makes it easier to compare implementation and stubs and keep them in sync.

@Eclips4 Eclips4 requested a review from srittau July 13, 2024 08:25
Copy link
Contributor

According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉

@srittau srittau merged commit 1eb6e22 into python:main Jul 13, 2024
63 checks passed
@Eclips4 Eclips4 deleted the mimetypes-add_type branch July 13, 2024 08:56
max-muoto pushed a commit to max-muoto/typeshed that referenced this pull request Jul 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants