Resolve asyncio issues for 3.13 #12327
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This comment has been minimized.
This comment has been minimized.
srittau
requested changes
Jul 12, 2024
| @@ -237,6 +243,7 @@ class BaseEventLoop(AbstractEventLoop): | |||
| ssl: _SSLContext = None, | |||
| reuse_address: bool | None = None, | |||
| reuse_port: bool | None = None, | |||
| keep_alive: bool | None = None, | |||
There was a problem hiding this comment.
Weird that the default is None, not False, but it is what it is ...
| class QueueEmpty(Exception): ... | ||
| class QueueFull(Exception): ... | ||
|
|
||
| if sys.version_info >= (3, 13): | ||
| class QueueShutDown(Exception): ... | ||
| __all__ = ("Queue", "PriorityQueue", "LifoQueue", "QueueFull", "QueueEmpty", "QueueShutDown") |
There was a problem hiding this comment.
__all__ should stay at the top of the file (below the imports), even if it means repeating the version_info branch.
There was a problem hiding this comment.
Addressed: bee3ed2
stdlib/asyncio/unix_events.pyi
Outdated
| @@ -59,7 +62,19 @@ if sys.version_info < (3, 14): | |||
|
|
|||
| if sys.platform != "win32": | |||
| if sys.version_info >= (3, 14): | |||
| __all__ = ("SelectorEventLoop", "DefaultEventLoopPolicy") | |||
| __all__ = ("SelectorEventLoop", "DefaultEventLoopPolicy", "EventLoop") | |||
There was a problem hiding this comment.
I have no idea why __all__ is down here, but you could also optionally move it to the top of the file.
There was a problem hiding this comment.
Addressed: bee3ed2
|
According to mypy_primer, this change has no effect on the checked open source code. 🤖🎉 |
srittau
approved these changes
Jul 13, 2024
max-muoto
added a commit
to max-muoto/typeshed
that referenced
this pull request
Jul 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Account for new
asynciochanges from 3.13:abort_clientsandclose_clientmethods onAbstractServer.keep_aliveparam forAbstractEventLoop.create_server.warningsargument forasyncio.Streams.StreamWriter.__del__QueueShutDownexception andshutdownmethod inayncio.queues.EventLooptounix_events.pyiandwindows_events.pyi.