Add PyCode_GetCode() function #34
Conversation
|
Wait until python/cpython#92168 is merged. |
| @@ -27,6 +27,12 @@ Latest version of the header file: | |||
| Python 3.11 | |||
| ----------- | |||
|
|
|||
| .. c:function:: PyObject* PyCode_GetCode(PyObject *code) | |||
There was a problem hiding this comment.
Nit: PyCodeObject *code not PyObject *code :)
There was a problem hiding this comment.
Fixed in commit bed155e.
| @@ -487,6 +487,15 @@ PyFloat_Unpack8(const char *p, int le) | |||
| #endif | |||
|
|
|||
|
|
|||
| // gh-92154 added PyCode_GetCode() to Python 3.11.0b1 | |||
| #if PY_VERSION_HEX < 0x030B00B1 && !defined(PYPY_VERSION) | |||
There was a problem hiding this comment.
Not sure if it matters, but this code will fail on one version: 3.11a7. In that version, co_code was removed, but there is no PyCode_GetCode.
I don't know what you should do here. Maybe exclude that version?
There was a problem hiding this comment.
Perhaps #error with an explanatory message.
There was a problem hiding this comment.
I don't know what you should do here. Maybe exclude that version?
Alpha versions of Python 3.11 are not supported:
pythoncapi-compat/tests/test_pythoncapi_compat.py
Lines 152 to 157 in c9764f5
It's a deliberate choice to not pollute pythoncapi_compat.h with ugly code to tons of compatibility layers, whereas there are few users of Python alpha versions.
Perhaps #error with an explanatory message.
What I suggested to users who want to upgrade pythoncapi_compat.h before Python 3.11 beta1 is to copy the file and then remove the functions which cause compilation errors. It's being discussed at: #32
There was a problem hiding this comment.
I'm not against adding an #error if you consider that it will help users impacted by this issue.
Python 3.11 beta1 is scheduled in a few days.
Python 3.11 breaks tons of C API: https://docs.python.org/dev/whatsnew/3.11.html#c-api-changes
In the past, I tried first to add getter functions in one Python version, and only change the structure in the following Python version. Well, the optimization work broke many structures (PyThreadState, PyFrameObject, PyCodeObject). But after beta1, the API should be stable.
No description provided.