PEP 562: Fix example by adding repr in an error message #2928
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CAM-Gerlach
changed the title
CAM-Gerlach
approved these changes
Dec 16, 2022
There was a problem hiding this comment.
LGTM at least as far as I'm concerned, this looks like a straightforward typo error in examples of the form we've usually merged before, and this very much isn't a drive-by trivial contributor here, so it seems worth it to me to just merge this, so long as the PR author doesn't object.
|
Also, to note, this PR's feature branch was created on the upstream repo instead of the author's fork, which will block final implementation of the remaining step of python/core-workflow#460 until it is merged or closed, so hopefully it can be resolved quickly 🙂 |
|
No objections here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first example in the PEP doesn't use
!rwhile formatting the name of the module and the attribute. The following example does. This PR fixes the first example so that it matches the second and the regular behavior of Python while trying to access a non-existing module variable.