Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PEP 581 Updates #1114

Merged
merged 2 commits into from
Jun 27, 2019
Merged

PEP 581 Updates #1114

merged 2 commits into from
Jun 27, 2019

Conversation

Mariatta
Copy link
Member

  • include recent changes to bpo
  • clarify the downsides of GitHub

@Mariatta
PEP 581 Updates
0764dd9 
- include recent changes to bpo
- clarify the downsides of GitHub
gvanrossum
gvanrossum reviewed Jun 27, 2019
View reviewed changes
Copy link
Member

@gvanrossum gvanrossum left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for doing this! Two nits.

pep-0581.rst Outdated Show resolved Hide resolved
pep-0581.rst Outdated Show resolved Hide resolved
@Mariatta
minor fixes
7d801db 
"not only"
"was" -> "is"
@gvanrossum
Copy link
Member

Thanks, LGTM.

@Mariatta Mariatta merged commit 5f56c05 into python:master Jun 27, 2019
@Mariatta Mariatta deleted the pep-581-updates branch June 27, 2019 21:43
@Mariatta
Copy link
Member Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum left review comments

Assignees
No one assigned
Labels
CLA signed
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Mariatta @gvanrossum @the-knights-who-say-ni