Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.10] gh-99845: _PyObject_DictPointer(): fix dictoffset cast (GH-99922) #99924

Merged
merged 1 commit into from
Dec 1, 2022
Merged

[3.10] gh-99845: _PyObject_DictPointer(): fix dictoffset cast (GH-99922) #99924

merged 1 commit into from
Dec 1, 2022

Conversation

miss-islington
Copy link
Contributor

@miss-islington miss-islington commented Dec 1, 2022 •
edited by bedevere-bot
Loading

Cast size_t to Py_ssize_t, rather than casting it to long. On 64-bit
Windows, long is 32-bit whereas Py_ssize_t is 64-bit.
(cherry picked from commit 9707bf2)

Co-authored-by: Victor Stinner vstinner@python.org

@vstinner @miss-islington
pythongh-99845: _PyObject_DictPointer(): fix dictoffset cast (pythonG…
ba5d5b3 
…H-99922)

Cast size_t to Py_ssize_t, rather than casting it to long. On 64-bit
Windows, long is 32-bit whereas Py_ssize_t is 64-bit.
(cherry picked from commit 9707bf2)

Co-authored-by: Victor Stinner <vstinner@python.org>
This was referenced Dec 1, 2022
Closed
Merged
vstinner
vstinner approved these changes Dec 1, 2022
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, good bot.

@miss-islington miss-islington merged commit 64dae2e into python:3.10 Dec 1, 2022
@miss-islington miss-islington deleted the backport-9707bf2-3.10 branch December 1, 2022 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miss-islington @vstinner @bedevere-bot