_overload_dummy raises NotImplementedError, not RuntimeError

[sobolevn]

Source:

cpython/Lib/typing.py

Lines 2536 to 2542 in eae7dad

	def _overload_dummy(*args, **kwds):
	"""Helper for @overload to raise when called."""
	raise NotImplementedError(
	"You should not call an overloaded function. "
	"A series of @overload-decorated functions "
	"outside a stub module should always be followed "
	"by an implementation that is not @overload-ed.")

I've found this while looking for implicit abstract classes / methods in CPython.

Test was checking for RuntimeError, it is technically correct:

>>> NotImplementedError.__mro__
(<class 'NotImplementedError'>, <class 'RuntimeError'>, <class 'Exception'>, <class 'BaseException'>, <class 'object'>)

But, we can be more precise. It is a good thing.
I am going to skip creating an issue for this, it is like a typo-fix :)

[JelleZijlstra]

Thanks for catching this!

I feel like RuntimeError is a better exception to throw than NotImplementedError here, but we've apparently always used NotImplementedError and it's not worth changing.

[miss-islington]

Thanks @sobolevn for the PR, and @JelleZijlstra for merging it 🌮🎉.. I'm working now to backport this PR to: 3.10, 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

[miss-islington]

Sorry, @sobolevn and @JelleZijlstra, I could not cleanly backport this to 3.10 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker 1ca6647f22794f0a0c982ecb03e764db76d51087 3.10

[bedevere-bot]

GH-98470 is a backport of this pull request to the 3.11 branch.

[JelleZijlstra]

These tests don't exist in 3.10.