Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-97837: Change deprecation warning message in unittest #97838

Merged
merged 1 commit into from
Oct 5, 2022
Merged

gh-97837: Change deprecation warning message in unittest #97838

merged 1 commit into from
Oct 5, 2022

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Oct 4, 2022 •
edited by bedevere-bot
Loading

@sobolevn sobolevn requested a review from vsajip as a code owner October 4, 2022 18:22
@vsajip vsajip removed their request for review October 4, 2022 19:42
@vsajip
Copy link
Member

vsajip commented Oct 4, 2022

Not sure if I was added as a reviewer by mistake - I don't seem to be an owner for any of these areas.

orsenthil
orsenthil approved these changes Oct 5, 2022
View reviewed changes
Copy link
Member

@orsenthil orsenthil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Verified and LGTM.

@orsenthil orsenthil added the needs backport to 3.11 only security fixes label Oct 5, 2022
@orsenthil orsenthil merged commit c3648f4 into python:main Oct 5, 2022
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@orsenthil orsenthil added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Oct 5, 2022
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@ezio-melotti ezio-melotti removed the needs backport to 3.11 only security fixes label Oct 5, 2022
orsenthil pushed a commit that referenced this pull request Oct 5, 2022
@sobolevn @orsenthil
[3.11] gh-97837: Change deprecation warning message in unittest (GH…
fceb0ca 
…-97838)

(cherry picked from commit c3648f4)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
@ezio-melotti ezio-melotti added the needs backport to 3.11 only security fixes label Oct 5, 2022
@miss-islington
Copy link
Contributor

Thanks @sobolevn for the PR, and @orsenthil for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-97887 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Oct 5, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Oct 5, 2022
@sobolevn @miss-islington
pythongh-97837: Change deprecation warning message in unittest (pyt…
8e8d5d4 
…honGH-97838)

(cherry picked from commit c3648f4)

Co-authored-by: Nikita Sobolev <mail@sobolevn.me>
miss-islington added a commit that referenced this pull request Oct 5, 2022
@miss-islington
[3.11] gh-97837: Change deprecation warning message in unittest (GH…
8c517d8 
…-97838) (GH-97887)

(cherry picked from commit c3648f4)


Co-authored-by: Nikita Sobolev <mail@sobolevn.me>

Automerge-Triggered-By: GH:orsenthil
mpage pushed a commit to mpage/cpython that referenced this pull request Oct 11, 2022
@sobolevn @mpage
pythongh-97837: Change deprecation warning message in unittest (pyt…
2eeacb0 
…hon#97838)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@orsenthil orsenthil orsenthil approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@sobolevn @vsajip @miss-islington @bedevere-bot @orsenthil @ezio-melotti