Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-87474: Fix file descriptor leaks in subprocess.Popen #96351

Merged
merged 5 commits into from
May 16, 2023
Merged

gh-87474: Fix file descriptor leaks in subprocess.Popen #96351

merged 5 commits into from
May 16, 2023

Commits on Mar 12, 2023

  1. Fix file descriptor leaks in subprocess.Popen

    @cptpcrd
    cptpcrd committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    6270ccd View commit details
    Browse the repository at this point in the history

  2. Refactor to use context manager 

    Simplifies the logic and should help avoid mistakes in the future.

Co-authored-by: Gregory P. Smith <greg@krypto.org>
    @cptpcrd @gpshead
    cptpcrd and gpshead committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    783e6f8 View commit details
    Browse the repository at this point in the history

  3. Move err_close_fds adds next to pipe creation.

    @gpshead @cptpcrd
    gpshead authored and cptpcrd committed Mar 12, 2023
    Configuration menu
    Copy the full SHA
    0d4efba View commit details
    Browse the repository at this point in the history

Commits on May 16, 2023

  1. add ReST formatting to NEWS.

    @gpshead
    gpshead authored May 16, 2023
    Configuration menu
    Copy the full SHA
    0265ce7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'main' into subprocess-fd-leak

    @gpshead
    gpshead authored May 16, 2023
    Configuration menu
    Copy the full SHA
    1b7b0f4 View commit details
    Browse the repository at this point in the history