Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-90016: Deprecate default sqlite3 adapters and converters #94276

Merged
merged 9 commits into from
Jul 20, 2022
Merged

gh-90016: Deprecate default sqlite3 adapters and converters #94276

merged 9 commits into from
Jul 20, 2022

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 25, 2022 •
edited
Loading

Closes gh-90016

@erlend-aasland erlend-aasland mentioned this pull request Jun 25, 2022
Closed
@erlend-aasland
Copy link
Contributor Author

cc. @iafisher: would you mind reviewing this?

iafisher
iafisher reviewed Jun 25, 2022
View reviewed changes
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Lib/sqlite3/dbapi2.py Show resolved Hide resolved
Erlend Egeberg Aasland and others added 2 commits June 27, 2022 18:00
CAM-Gerlach
CAM-Gerlach reviewed Jun 29, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @erlend-aasland , and sorry for the delay! Just a handful of textual and reST/Sphinx fixes/suggestions.

Doc/library/sqlite3.rst Show resolved Hide resolved
Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
Misc/NEWS.d/next/Library/2022-06-25-23-44-44.gh-issue-90016.EB409s.rst Outdated Show resolved Hide resolved
Lib/sqlite3/dbapi2.py Outdated Show resolved Hide resolved
Doc/library/sqlite3.rst Show resolved Hide resolved
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
Doc/library/sqlite3.rst Show resolved Hide resolved
Doc/library/sqlite3.rst Outdated Show resolved Hide resolved
AlexWaygood
AlexWaygood reviewed Jul 1, 2022
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Again, +1 to most of Cam's thoughts

@erlend-aasland
Copy link
Contributor Author

Reviews addressed in d3dd3b4

CAM-Gerlach
CAM-Gerlach approved these changes Jul 2, 2022
View reviewed changes
Copy link
Member

@CAM-Gerlach CAM-Gerlach left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @erlend-aasland ! Just two minor fixes, both my mistake.

Misc/NEWS.d/next/Library/2022-06-25-23-44-44.gh-issue-90016.EB409s.rst Outdated Show resolved Hide resolved
Doc/whatsnew/3.12.rst Outdated Show resolved Hide resolved
Erlend Egeberg Aasland and others added 2 commits July 2, 2022 08:34
@CAM-Gerlach
Update Misc/NEWS.d/next/Library/2022-06-25-23-44-44.gh-issue-90016.EB…
df4dc31 
…409s.rst

Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@CAM-Gerlach
Update Doc/whatsnew/3.12.rst
ffdf631 
Co-authored-by: CAM Gerlach <CAM.Gerlach@Gerlach.CAM>
@erlend-aasland
Copy link
Contributor Author

@felixxm, I guess this change is ok with Django; AFAIK, you use your own adapters/converters?

@serhiy-storchaka and @malemburg, would you two mind reviewing this?

@felixxm
Copy link
Contributor

felixxm commented Jul 4, 2022

@felixxm, I guess this change is ok with Django; AFAIK, you use your own adapters/converters?

Yes, it works for us 👍 Thanks for letting me know 🎁 . I prepared PR with missing adapters/converters for Django, see django/django#15815.

felixxm
felixxm approved these changes Jul 4, 2022
View reviewed changes
Copy link
Contributor

@felixxm felixxm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@erlend-aasland Thanks 👍

Lib/sqlite3/dbapi2.py Outdated Show resolved Hide resolved
@erlend-aasland
Copy link
Contributor Author

I'll resolve the conflicts and land this PR later tonight.

@erlend-aasland erlend-aasland merged commit 6dadf6c into python:main Jul 20, 2022
@erlend-aasland erlend-aasland deleted the sqlite-deprecate-adapters branch July 20, 2022 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@iafisher iafisher iafisher left review comments

@AlexWaygood AlexWaygood AlexWaygood left review comments

@felixxm felixxm felixxm approved these changes

@CAM-Gerlach CAM-Gerlach CAM-Gerlach approved these changes

@berkerpeksag berkerpeksag Awaiting requested review from berkerpeksag berkerpeksag is a code owner

@serhiy-storchaka serhiy-storchaka Awaiting requested review from serhiy-storchaka

@malemburg malemburg Awaiting requested review from malemburg

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Deprecate default converters in sqlite3
6 participants
@erlend-aasland @felixxm @iafisher @CAM-Gerlach @AlexWaygood @bedevere-bot