Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-90699: Move generated static initializer to pycore_runtime_generated.h #94051

Merged
merged 3 commits into from
Jul 7, 2022
Merged

GH-90699: Move generated static initializer to pycore_runtime_generated.h #94051

merged 3 commits into from
Jul 7, 2022

Conversation

kumaraditya303
Copy link
Contributor

@kumaraditya303 kumaraditya303 commented Jun 21, 2022 •
edited by miss-islington
Loading

Automerge-Triggered-By: GH:ericsnowcurrently

@kumaraditya303 kumaraditya303 requested a review from a team as a code owner June 21, 2022 09:42
@kumaraditya303 kumaraditya303 changed the title GH-90699: Move generated static intializer to pycore_runtime_generated.h GH-90699: Move generated static initializer to pycore_runtime_generated.h Jun 21, 2022
@kumaraditya303 kumaraditya303 mentioned this pull request Jun 24, 2022
Merged
@ericsnowcurrently
Copy link
Member

Is this related to #93597 (comment)?

@kumaraditya303
Copy link
Contributor Author

Is this related to #93597 (comment)?

Yes.

ericsnowcurrently
ericsnowcurrently approved these changes Jul 6, 2022
View reviewed changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

I'm approving the PR but left a couple non-critical comments which I'd like resolved (at least an agreement that what you have is okay) before merging.

Include/internal/pycore_runtime_init.h Outdated Show resolved Hide resolved
Include/internal/pycore_runtime_generated.h Outdated Show resolved Hide resolved
@ericsnowcurrently
Copy link
Member

Are you going to do something similar for the generated code in pycore_global_strings.h?

@kumaraditya303
Copy link
Contributor Author

Are you going to do something similar for the generated code in pycore_global_strings.h?

I will probably merge the generated code from pycore_global_strings.h in the same file as this one but that's for another day.

@miss-islington miss-islington merged commit 7169766 into python:main Jul 7, 2022
@kumaraditya303 kumaraditya303 deleted the generated branch July 8, 2022 07:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kumaraditya303 @ericsnowcurrently @bedevere-bot @miss-islington