[3.11] GH-93516: Speedup line number checks when tracing. (GH-93763) #94023
Conversation
|
The ABI breakage is not really a break, as the new field is inserted (almost) at the end, after any other fields used in C extensions. |
| @@ -278,6 +279,7 @@ def generate_code(self, name: str, code: types.CodeType) -> str: | |||
| self.write(f".co_name = {co_name},") | |||
| self.write(f".co_qualname = {co_qualname},") | |||
| self.write(f".co_linetable = {co_linetable},") | |||
| self.write("._co_linearray = NULL,") | |||
There was a problem hiding this comment.
Sorry, unrelated question, but does this mean I need to add the field from my _co_code change here too?
There was a problem hiding this comment.
Technically, no. C will initialize any fields not explicitly mentioned to zero.
I think it is good practice to be explicit, though.
|
I will regenerate the ABI in this PR |
|
@markshannon I cannot push to the remote repo, could you please ensure the "allow pushes from maintainers checkbox is activated on the right column"? |
|
There is no "allow pushes from maintainers" checkbox. |
|
Closing in favour of #94127 to allow edits. |
Backport of #93763