Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-79579: Improve DML query detection in sqlite3 #93623

Merged
merged 22 commits into from
Jun 14, 2022
Merged

gh-79579: Improve DML query detection in sqlite3 #93623

merged 22 commits into from
Jun 14, 2022

Commits on Jun 8, 2022

  1. Add tests

    @erlend-aasland
    erlend-aasland committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    c8bcf3b View commit details
    Browse the repository at this point in the history

  2. Modify pysqlite_check_remaining_sql to return char * iso. int

    @erlend-aasland
    erlend-aasland committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    d38e632 View commit details
    Browse the repository at this point in the history

  3. Rename pysqlite_check_remaining_sql to lstrip_sql

    @erlend-aasland
    erlend-aasland committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    7fcca68 View commit details
    Browse the repository at this point in the history

  4. Use lstrip_sql() to strip comments and whitespace

    @erlend-aasland
    erlend-aasland committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    3061dc5 View commit details
    Browse the repository at this point in the history

  5. Adjust comment

    @erlend-aasland
    erlend-aasland committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    631f24d View commit details
    Browse the repository at this point in the history

  6. Explicit comparison

    @erlend-aasland
    erlend-aasland committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    8f29283 View commit details
    Browse the repository at this point in the history

  7. Add more tests

    @erlend-aasland
    erlend-aasland committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    a51cfe6 View commit details
    Browse the repository at this point in the history

  8. Fix bug in lstrip parser

    @erlend-aasland
    erlend-aasland committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    bf0e150 View commit details
    Browse the repository at this point in the history

  9. Adjust NEWS

    @erlend-aasland
    erlend-aasland committed Jun 8, 2022
    Configuration menu
    Copy the full SHA
    5918fbe View commit details
    Browse the repository at this point in the history

Commits on Jun 9, 2022

  1. Make test more messy

    @erlend-aasland
    erlend-aasland committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    b45e5b5 View commit details
    Browse the repository at this point in the history

  2. Address Ma Lin's review 

    - normalise switch cases
- improve NEWS entry accuracy
    @erlend-aasland
    erlend-aasland committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    b0a7fbc View commit details
    Browse the repository at this point in the history

  3. Reword comment

    @erlend-aasland
    erlend-aasland committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    61a81eb View commit details
    Browse the repository at this point in the history

  4. Inline it

    @erlend-aasland
    erlend-aasland committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    e3fea31 View commit details
    Browse the repository at this point in the history

  5. Further mess up messy test to increase code coverage

    @erlend-aasland
    erlend-aasland committed Jun 9, 2022
    Configuration menu
    Copy the full SHA
    d6ce75c View commit details
    Browse the repository at this point in the history

Commits on Jun 10, 2022

  1. Increase code coverage

    @erlend-aasland
    erlend-aasland committed Jun 10, 2022
    Configuration menu
    Copy the full SHA
    7f7943f View commit details
    Browse the repository at this point in the history

Commits on Jun 12, 2022

  1. Merge branch 'main' into sqlite-rowcount/pythongh-79579-alt

    @erlend-aasland
    erlend-aasland committed Jun 12, 2022
    Configuration menu
    Copy the full SHA
    adcba2c View commit details
    Browse the repository at this point in the history

Commits on Jun 13, 2022

  1. Rewrite lstrip_sql by borrowing from SQLite's parser

    @erlend-aasland
    erlend-aasland committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    e5fafc7 View commit details
    Browse the repository at this point in the history

  2. Test code nit

    @erlend-aasland
    erlend-aasland committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    7d7a654 View commit details
    Browse the repository at this point in the history

  3. Harden test_rowcount_prefixed_with_comment test 

    Make sure a different rowcount is returned for each query
    @erlend-aasland
    erlend-aasland committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    2e638a0 View commit details
    Browse the repository at this point in the history

  4. Simplify one test

    @erlend-aasland
    erlend-aasland committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    b932e4f View commit details
    Browse the repository at this point in the history

  5. Fix ret value for invalid comments

    @erlend-aasland
    erlend-aasland committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    ca053d7 View commit details
    Browse the repository at this point in the history

  6. Simplify

    @erlend-aasland
    erlend-aasland committed Jun 13, 2022
    Configuration menu
    Copy the full SHA
    c6fa9b2 View commit details
    Browse the repository at this point in the history