Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-93345: Fix a crash in substitution of nested TypeVar after TypeVarTuple #93346

Merged
merged 3 commits into from
May 31, 2022
Merged

gh-93345: Fix a crash in substitution of nested TypeVar after TypeVarTuple #93346

merged 3 commits into from
May 31, 2022
+10 −2

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented May 30, 2022 •
edited
Loading

Closes #93345.

@serhiy-storchaka serhiy-storchaka added type-crash A hard crash of the interpreter, possibly with a core dump needs backport to 3.11 only security fixes labels May 30, 2022
@serhiy-storchaka serhiy-storchaka marked this pull request as ready for review May 30, 2022 07:25
@serhiy-storchaka @Fidget-Spinner
Update Misc/NEWS.d/next/Core and Builtins/2022-05-30-10-22-46.gh-issu…
936f4ac 
…e-93345.gi1A4L.rst

Co-authored-by: Ken Jin <kenjin4096@gmail.com>
@serhiy-storchaka serhiy-storchaka merged commit f545fc9 into python:main May 31, 2022
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@serhiy-storchaka serhiy-storchaka deleted the typing-subst-nested-typevar-after-typevartuple branch May 31, 2022 05:46
@miss-islington
Copy link
Contributor

Sorry, @serhiy-storchaka, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker f545fc955aeb701ae4e73b07ff2283f823d857b8 3.11

@serhiy-storchaka serhiy-storchaka added needs backport to 3.11 only security fixes and removed needs backport to 3.11 only security fixes labels Jun 1, 2022
@miss-islington
Copy link
Contributor

Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 1, 2022
@serhiy-storchaka @miss-islington
pythongh-93345: Fix a crash in substitution of nested TypeVar after T…
ba4da2a 
…ypeVarTuple (pythonGH-93346)

For example: tuple[*Ts, list[T]][int, str, bool]
(cherry picked from commit f545fc9)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@bedevere-bot
Copy link

GH-93402 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 1, 2022
miss-islington added a commit that referenced this pull request Jun 1, 2022
@miss-islington @serhiy-storchaka
gh-93345: Fix a crash in substitution of nested TypeVar after TypeVar…
3265ff9 
…Tuple (GH-93346)

For example: tuple[*Ts, list[T]][int, str, bool]
(cherry picked from commit f545fc9)

Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
@serhiy-storchaka serhiy-storchaka removed their assignment Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Fidget-Spinner Fidget-Spinner Fidget-Spinner approved these changes

@gvanrossum gvanrossum Awaiting requested review from gvanrossum

@JelleZijlstra JelleZijlstra Awaiting requested review from JelleZijlstra JelleZijlstra is a code owner

Assignees
No one assigned
Labels
type-crash A hard crash of the interpreter, possibly with a core dump
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Crash in substitution of nested TypeVar after TypeVarTuple
4 participants
@serhiy-storchaka @miss-islington @bedevere-bot @Fidget-Spinner