Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46541: Remove usage of _Py_IDENTIFIER from multibytecodec #31475

Merged
merged 3 commits into from
Mar 1, 2022
Merged

bpo-46541: Remove usage of _Py_IDENTIFIER from multibytecodec #31475

merged 3 commits into from
Mar 1, 2022

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Feb 21, 2022 •
edited by bedevere-bot
Loading

@terryjreedy
Copy link
Member

terryjreedy commented Feb 21, 2022 •
edited
Loading

In the issue number, 65 was transposed as 56. Fixed.

@terryjreedy terryjreedy changed the title bpo-45641: Remove usage of _Py_IDENTIFIER from multibytecodec bpo-46541: Remove usage of _Py_IDENTIFIER from multibytecodec Feb 21, 2022
kumaraditya303
kumaraditya303 approved these changes Feb 26, 2022
View reviewed changes
Copy link
Contributor

@kumaraditya303 kumaraditya303 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@corona10 corona10 mentioned this pull request Feb 26, 2022
Merged
tiran
tiran requested changes Feb 27, 2022
View reviewed changes
Modules/cjkcodecs/multibytecodec.c Outdated Show resolved Hide resolved
@bedevere-bot
Copy link

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@corona10
Copy link
Member Author

I have made the requested changes; please review again

@bedevere-bot
Copy link

Thanks for making the requested changes!

@tiran: please review the changes made to this pull request.

@corona10
Copy link
Member Author

corona10 commented Mar 1, 2022

After some discussion, I decided to merge this PR anyway.
I will accept the other approach if someone wants :) I hope that this approach would help to reduce the usage of private APIs
cc @ericsnowcurrently, @erlend-aasland, @tiran, @vstinner (alphabetical order :)

@corona10 corona10 merged commit 0cc6364 into python:main Mar 1, 2022
@corona10 corona10 deleted the bpo-46541-multibytecodec branch March 1, 2022 14:35
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jul 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@vstinner vstinner Awaiting requested review from vstinner

@tiran tiran Awaiting requested review from tiran

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@corona10 @terryjreedy @bedevere-bot @tiran @erlend-aasland @kumaraditya303 @the-knights-who-say-ni