Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46541: Remove usage of _Py_IDENTIFIER from pyexpat #31468

Merged
merged 2 commits into from
Feb 21, 2022
Merged

bpo-46541: Remove usage of _Py_IDENTIFIER from pyexpat #31468

merged 2 commits into from
Feb 21, 2022

Conversation

corona10
Copy link
Member

@corona10 corona10 commented Feb 21, 2022 •
edited by bedevere-bot
Loading

@erlend-aasland
Copy link
Contributor

Please also remove #define NEEDS_PY_IDENTIFIER

@corona10
Copy link
Member Author

@erlend-aasland
Ah thanks nice catch :)

erlend-aasland
erlend-aasland approved these changes Feb 21, 2022
View reviewed changes
Copy link
Contributor

@erlend-aasland erlend-aasland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 😃

@corona10 corona10 merged commit 2b86616 into python:main Feb 21, 2022
@corona10 corona10 deleted the bpo-46541-pyexpat branch February 21, 2022 14:46
@ericsnowcurrently ericsnowcurrently mentioned this pull request Jul 9, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@vstinner vstinner Awaiting requested review from vstinner

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@corona10 @erlend-aasland @the-knights-who-say-ni @bedevere-bot