Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-46278: Reflect 'context' arg in 'AbstractEventLoop.call_*()' methods #30427

Merged
merged 1 commit into from
Jan 6, 2022
Merged

bpo-46278: Reflect 'context' arg in 'AbstractEventLoop.call_*()' methods #30427

merged 1 commit into from
Jan 6, 2022

Conversation

asvetlov
Copy link
Contributor

@asvetlov asvetlov commented Jan 6, 2022 •
edited by bedevere-bot
Loading

@asvetlov asvetlov added needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes labels Jan 6, 2022
@asvetlov asvetlov requested a review from 1st1 as a code owner January 6, 2022 11:39
kumaraditya303
kumaraditya303 reviewed Jan 6, 2022
View reviewed changes
Lib/asyncio/events.py
raise NotImplementedError

def call_at(self, when, callback, *args):
def call_at(self, when, callback, *args, cotext=None):
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
def call_at(self, when, callback, *args, cotext=None):
def call_at(self, when, callback, *args, context=None):

@asvetlov asvetlov merged commit 3e43fac into main Jan 6, 2022
@asvetlov asvetlov deleted the fix-asyncio-contracts branch January 6, 2022 12:31
@miss-islington
Copy link
Contributor

Thanks @asvetlov for the PR 🌮🎉.. I'm working now to backport this PR to: 3.9, 3.10.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 6, 2022
@asvetlov @miss-islington
Reflect 'context' arg in 'AbstractEventLoop.call_*()' methods (python…
dbd74a9 
…GH-30427)

(cherry picked from commit 3e43fac)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@bedevere-bot
Copy link

GH-30428 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Jan 6, 2022
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 6, 2022
@asvetlov @miss-islington
Reflect 'context' arg in 'AbstractEventLoop.call_*()' methods (python…
aaf54d2 
…GH-30427)

(cherry picked from commit 3e43fac)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
@bedevere-bot
Copy link

GH-30429 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Jan 6, 2022
kumaraditya303 added a commit to kumaraditya303/cpython that referenced this pull request Jan 6, 2022
@kumaraditya303
fix typo introduced in pythonGH-30427
02e6131
asvetlov added a commit that referenced this pull request Jan 6, 2022
@miss-islington @asvetlov
Reflect 'context' arg in 'AbstractEventLoop.call_*()' methods (GH-30427…
0aa8bbf 
…) (#30429)

(cherry picked from commit 3e43fac)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
asvetlov added a commit that referenced this pull request Jan 6, 2022
@miss-islington @asvetlov
Reflect 'context' arg in 'AbstractEventLoop.call_*()' methods (GH-30427…
8670fbe 
…) (GH-30428)

(cherry picked from commit 3e43fac)

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>

Co-authored-by: Andrew Svetlov <andrew.svetlov@gmail.com>
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 6, 2022
@kumaraditya303 @miss-islington
bpo-46278: fix typo introduced in pythonGH-30427 (pythonGH-30430)
76327d0 
Automerge-Triggered-By: GH:asvetlov
(cherry picked from commit b50e5e9)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
miss-islington pushed a commit that referenced this pull request Jan 6, 2022
@kumaraditya303
bpo-46278: fix typo introduced in GH-30427 (GH-30430)
b50e5e9 
Automerge-Triggered-By: GH:asvetlov
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jan 6, 2022
@kumaraditya303 @miss-islington
bpo-46278: fix typo introduced in pythonGH-30427 (pythonGH-30430)
fde9dc2 
Automerge-Triggered-By: GH:asvetlov
(cherry picked from commit b50e5e9)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
miss-islington added a commit that referenced this pull request Jan 6, 2022
@miss-islington @kumaraditya303
bpo-46278: fix typo introduced in GH-30427 (GH-30430)
cb06831 
Automerge-Triggered-By: GH:asvetlov
(cherry picked from commit b50e5e9)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
asvetlov pushed a commit that referenced this pull request Jan 6, 2022
@miss-islington @kumaraditya303
bpo-46278: fix typo introduced in GH-30427 (GH-30430) (GH-30431)
861a9aa 
Automerge-Triggered-By: GH:asvetlov
(cherry picked from commit b50e5e9)

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>

Co-authored-by: Kumar Aditya <59607654+kumaraditya303@users.noreply.github.com>
@gvanrossum gvanrossum mentioned this pull request Aug 28, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kumaraditya303 kumaraditya303 kumaraditya303 left review comments

@1st1 1st1 Awaiting requested review from 1st1 1st1 is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@asvetlov @miss-islington @bedevere-bot @kumaraditya303 @the-knights-who-say-ni