bpo-42937: Update ipaddress.py to include additional private range of IPs #26205
Conversation
…f IPs
There is a lot more IPs in the private address range. I will create a separate issue for that. This makes this a very simple request. I verified the IP and that it is not routeable globally according according to IANA. This is my first PR for cpython. Please let me know if bpo or anything like that is not correct.
https://www.iana.org/assignments/iana-ipv4-special-registry/iana-ipv4-special-registry.xhtml
…f IPs
There is a lot more IPs in the private address range. I will create a separate issue for that. This makes this a very simple request. I verified the IP and that it is not routeable globally according according to IANA. This is my first PR for cpython. Please let me know if bpo or anything like that is not correct.
https://www.iana.org/assignments/iana-ipv4-special-registry/iana-ipv4-special-registry.xhtml
|
Hello, and thanks for your contribution! I'm a bot set up to make sure that the project can legally accept this contribution by verifying everyone involved has signed the PSF contributor agreement (CLA). CLA MissingOur records indicate the following people have not signed the CLA: For legal reasons we need all the people listed to sign the CLA before we can look at your contribution. Please follow the steps outlined in the CPython devguide to rectify this issue. If you have recently signed the CLA, please wait at least one business day You can check yourself to see if the CLA has been received. Thanks again for the contribution, we look forward to reviewing it! |
|
I have now signed a CLA. |
|
I note that the list is not complete; unless the IANA marks a subset of 192.0.0.0/24 as globally reachable in future, all of that subnet except for 192.0.0.9/32 and 192.0.0.10/32 should be considered private. See my comments on the associated issue. |
There was a problem hiding this comment.
Please review last comment. I am addressing this one IP to address the CR. I am more than willing to update the private and special IPs as declared by IANA and hopefully remove some of the confusion. This is ready to go, pending this approved. This change does specifically address this CR. First time submitting so just want to get used to the process.
|
This PR is stale because it has been open for 30 days with no activity. |
|
How can we make this no stale and move forward?
From: github-actions[bot] ***@***.***>
Sent: June-29-21 6:05 PM
To: python/cpython ***@***.***>
Cc: wjohnston888 ***@***.***>; Comment ***@***.***>
Subject: [EXTERNAL] Re: [python/cpython] [bpo-42937](https://bugs.python.org/issue42937): Update ipaddress.py to include additional private range of IPs (#26205)
This PR is stale because it has been open for 30 days with no activity.
—
You are receiving this because you commented.
Reply to this email directly, view it on GitHub<#26205 (comment)>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/AGL4M6MWUGROD6A3YLT7ZCLTVJNSFANCNFSM45BS6GEQ>.
|
github-actions
bot
removed
the
stale
|
Is there anyway to move this forward. |
https://bugs.python.org/issue42937