Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bpo-41858: Fix incomplete line on optparse documentation #22407

Merged
merged 2 commits into from
Sep 27, 2020

Conversation

eamanu
Copy link
Contributor

@eamanu eamanu commented Sep 25, 2020

This line seems to be incomplete. This fix come from the translation
to spanish of @fjsevilla-dev on python/python-docs-es#758.
reading the proposal for the translate has sense add the next lines.

I thinks that NEWS could be ignore here.

https://bugs.python.org/issue41858

This line seems to be incomplete. This fix come from the translation
to spanish of @fjsevilla-dev on python/python-docs-es#758.
reading the proposal for the translate has sense add `the next lines`.
Copy link
Contributor

@taleinat taleinat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In my eyes (I'm a native English speaker but not a language expert), "the following lines" is not required, though I agree that this sentence is slightly too terse without it.

I'd change this to "users can run either one of:".

@taleinat
Copy link
Contributor

On second thought, I prefer @terryjreedy's suggestion on the b.p.o. issue.

@terryjreedy terryjreedy self-assigned this Sep 27, 2020
@terryjreedy terryjreedy added needs backport to 3.8 only security fixes needs backport to 3.9 only security fixes labels Sep 27, 2020
@terryjreedy terryjreedy merged commit 00eb063 into python:master Sep 27, 2020
@miss-islington
Copy link
Contributor

Thanks @eamanu for the PR, and @terryjreedy for merging it 🌮🎉.. I'm working now to backport this PR to: 3.8, 3.9.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2020
The existing line is easily read as being incomplete.
(cherry picked from commit 00eb063)

Co-authored-by: Emmanuel Arias <eamanu@yaerobi.com>
@bedevere-bot
Copy link

GH-22425 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Sep 27, 2020
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 27, 2020
The existing line is easily read as being incomplete.
(cherry picked from commit 00eb063)

Co-authored-by: Emmanuel Arias <eamanu@yaerobi.com>
@bedevere-bot
Copy link

GH-22426 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Sep 27, 2020
miss-islington added a commit that referenced this pull request Sep 27, 2020
The existing line is easily read as being incomplete.
(cherry picked from commit 00eb063)

Co-authored-by: Emmanuel Arias <eamanu@yaerobi.com>
miss-islington added a commit that referenced this pull request Sep 27, 2020
The existing line is easily read as being incomplete.
(cherry picked from commit 00eb063)

Co-authored-by: Emmanuel Arias <eamanu@yaerobi.com>
shihai1991 added a commit to shihai1991/cpython that referenced this pull request Sep 29, 2020
* origin/master: (113 commits)
  bpo-41773: Raise exception for non-finite weights in random.choices().  (pythonGH-22441)
  bpo-41873: Add vectorcall for float() (pythonGH-22432)
  bpo-41861: Convert _sqlite3 PrepareProtocolType to heap type (pythonGH-22428)
  bpo-41842: Add codecs.unregister() function (pythonGH-22360)
  bpo-41875: Use __builtin_unreachable when possible (pythonGH-22433)
  bpo-40105: ZipFile truncate in append mode with shorter comment (pythonGH-19337)
  bpo-41870: Use PEP 590 vectorcall to speed up bool()  (pythonGH-22427)
  [doc] Leverage the fact that the actual types can now be indexed for typing (pythonGH-22340)
  bpo-41861: Convert _sqlite3 cache and node static types to heap types (pythonGH-22417)
  bpo-41858: Clarify line in optparse doc (pythonGH-22407)
  Revert "Fix all Python Cookbook links (python#22205)" (pythonGH-22424)
  bpo-1635741: Port _bisect module to multi-phase init (pythonGH-22415)
  bpo-41428: Fix compiler warning in unionobject.c (pythonGH-22416)
  Fix logging error message (pythonGH-22410)
  bpo-39934: Account for control blocks in 'except' in compiler. (pythonGH-22395)
  bpo-41775: Make 'IDLE Shell' the shell title  (python#22399)
  bpo-41428: Fix compiler warnings in unionobject.c (pythonGH-22388)
  bpo-41654: Fix compiler warning in MemoryError_dealloc() (pythonGH-22387)
  bpo-41833: threading.Thread now uses the target name (pythonGH-22357)
  bpo-30155: Add macros to get tzinfo from datetime instances (pythonGH-21633)
  ...
ambv pushed a commit to ambv/cpython that referenced this pull request Oct 4, 2020
The existing line is easily read as being incomplete.
(cherry picked from commit 00eb063)

Co-authored-by: Emmanuel Arias <eamanu@yaerobi.com>
xzy3 pushed a commit to xzy3/cpython that referenced this pull request Oct 18, 2020
The existing line is easily read as being incomplete.
@eamanu eamanu deleted the fix-optparsedoc branch November 8, 2020 15:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Documentation in the Doc dir skip news
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants