bpo-1635741 port _lsprof to multi-phase init (PEP 489) #22220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vstinner @corona10 @shihai1991 please review |
|
compile warning: |
Oops, I meant to remove that! |
vstinner
reviewed
Sep 14, 2020
koubaa
force-pushed
the
bpo-1635741-lsprof
branch
from
ae2e03e
to
d4800d3
Compare
koubaa
force-pushed
the
bpo-1635741-lsprof
branch
from
d4800d3
to
1a01fed
Compare
vstinner
approved these changes
Sep 22, 2020
Modules/_lsprof.c
Outdated
| @@ -479,27 +489,23 @@ static PyStructSequence_Field profiler_subentry_fields[] = { | |||
|
|
|||
| static PyStructSequence_Desc profiler_entry_desc = { | |||
| "_lsprof.profiler_entry", /* name */ | |||
| NULL, /* doc */ | |||
| "", /* doc */ | |||
There was a problem hiding this comment.
IMO PyType_FromSpec() should accept tp_doc=NULL, I created: https://bugs.python.org/issue41832
I don't ask you to change your PR, "" vs NULL can be changed again later.
vstinner
approved these changes
Sep 23, 2020
| .name = "_lsprof.profiler_entry", | ||
| .doc = "", | ||
| .fields = profiler_entry_fields, | ||
| .n_in_sequence = 6 |
There was a problem hiding this comment.
For me, it's way easier to read than the old format, thanks!
| if (PyModule_AddType(module, state->stats_subentry_type) < 0) { | ||
| return -1; | ||
| } | ||
|
|
There was a problem hiding this comment.
Thanks, the new code is more regular (create type, add type, create type, add type, ...) and so easier to read!
shihai1991
added a commit
to shihai1991/cpython
that referenced
this pull request
Sep 24, 2020
* origin/master: (27 commits) bpo-41428: Fix compiler warnings in unionobject.c (pythonGH-22388) bpo-41654: Fix compiler warning in MemoryError_dealloc() (pythonGH-22387) bpo-41833: threading.Thread now uses the target name (pythonGH-22357) bpo-30155: Add macros to get tzinfo from datetime instances (pythonGH-21633) bpo-33822: Update IDLE section of What's New 3.8 (pythonGH-22383) bpo-41844: Add IDLE section to What's New 3.9 (GN-22382) bpo-41841: Prepare IDLE News for 3.10 (pythonGH-22379) bpo-37779 : Add information about the overriding behavior of ConfigParser.read (pythonGH-15177) bpo-40170: Use inline _PyType_HasFeature() function (pythonGH-22375) bpo-40941: Fix stackdepth compiler warnings (pythonGH-22377) bpo-40941: Fix fold_tuple_on_constants() compiler warnings (pythonGH-22378) bpo-40521: Fix PyUnicode_InternInPlace() (pythonGH-22376) bpo-41834: Remove _Py_CheckRecursionLimit variable (pythonGH-22359) bpo-1635741, unicodedata: add ucd_type parameter to UCD_Check() macro (pythonGH-22328) bpo-1635741: Port _lsprof extension to multi-phase init (PEP 489) (pythonGH-22220) bpo-41513: Improve order of adding fractional values. Improve variable names. (pythonGH-22368) bpo-41816: `StrEnum.__str__` is `str.__str__` (pythonGH-22362) bpo-35764: Rewrite the IDLE Calltips doc section (pythonGH-22363) bpo-41810: Reintroduce `types.EllipsisType`, `.NoneType` & `.NotImplementedType` (pythonGH-22336) bpo-41602: raise SIGINT exit code on KeyboardInterrupt from pymain_run_module (python#21956) ...
xzy3
pushed a commit
to xzy3/cpython
that referenced
this pull request
Oct 18, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://bugs.python.org/issue1635741