Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40275: Fix a calling bug in threading_helper #20479

Closed
wants to merge 1 commit into from
Closed

bpo-40275: Fix a calling bug in threading_helper #20479

wants to merge 1 commit into from

Conversation

shihai1991
Copy link
Member

@shihai1991 shihai1991 commented May 28, 2020 •
edited by bedevere-bot
Loading

@shihai1991
Copy link
Member Author

TODO: test tools should have unittest too.

@shihai1991
Copy link
Member Author

@vstinner Hi, victor. Pls take a look if you have free time. Sorry, I introduced a potential bug in threading_helper :(

@vstinner
Copy link
Member

Oh right, there are a few more:

$ pyflakes Lib/test/support/threading_helper.py 
Lib/test/support/threading_helper.py:50:9 undefined name 'gc_collect'
Lib/test/support/threading_helper.py:101:13 undefined name 'gc_collect'
Lib/test/support/threading_helper.py:127:16 undefined name 'verbose'
Lib/test/support/threading_helper.py:136:23 local variable 'starttime' is assigned to but never used
Lib/test/support/threading_helper.py:144:20 undefined name 'verbose'
Lib/test/support/threading_helper.py:150:45 undefined name 'sys'

@vstinner vstinner mentioned this pull request May 28, 2020
Merged
@vstinner
Copy link
Member

vstinner commented May 28, 2020 •
edited
Loading

These bugs caused multiple buildbots failures: #20448 (comment)

I created PR #20488 to fix all pyflakes warning.

@vstinner
Copy link
Member

@vstinner Hi, victor. Pls take a look if you have free time. Sorry, I introduced a potential bug in threading_helper :(

That's ok. I didn't spot these issues neither, and test_support passed.

@vstinner
Copy link
Member

I merged my #20488 instead.

@vstinner vstinner closed this May 28, 2020
@shihai1991
Copy link
Member Author

I merged my #20488 instead.

Got it, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@shihai1991 @vstinner @the-knights-who-say-ni @bedevere-bot