Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.13] bpo-34206: Improve docs and test coverage for pre-init functions (GH-8023) #125092

Merged
merged 1 commit into from
Oct 8, 2024

Conversation

ncoghlan
Copy link
Contributor

@ncoghlan ncoghlan commented Oct 8, 2024

  • move the Py_Main documentation from the very high level API section
    to the initialization and finalization section
  • make it clear that it encapsulates a full Py_Initialize/Finalize cycle of its own
  • point out that exactly which settings will be read and applied correctly when
    Py_Main is called after a separate runtime initialization call is version dependent
  • be explicit that Py_IsInitialized can be called prior to initialization
  • actually test that Py_IsInitialized can be called prior to initialization
  • flush stdout in the embedding tests that run code so it appears
    in the expected order when running with "-vv"
  • make "-vv" on the subinterpreter embedding tests less spammy

(cherry picked from commit 7c4b6a6)


📚 Documentation preview 📚: https://cpython-previews--125092.org.readthedocs.build/

…ns (pythonGH-8023)

- move the Py_Main documentation from the very high level API section
  to the initialization and finalization section
- make it clear that it encapsulates a full Py_Initialize/Finalize
  cycle of its own
- point out that exactly which settings will be read and applied
  correctly when Py_Main is called after a separate runtime
  initialization call is version dependent
- be explicit that Py_IsInitialized can be called prior to
  initialization
- actually test that Py_IsInitialized can be called prior to
  initialization
- flush stdout in the embedding tests that run code so it appears
  in the expected order when running with "-vv"
- make "-vv" on the subinterpreter embedding tests less spammy

---------

(cherry picked from commit 7c4b6a6)

Co-authored-by: Alyssa Coghlan <ncoghlan@gmail.com>
Co-authored-by: Carol Willing <carolcode@willingconsulting.com>
@bedevere-app bedevere-app bot added tests Tests in the Lib/test dir awaiting core review labels Oct 8, 2024
@ncoghlan ncoghlan enabled auto-merge (squash) October 8, 2024 09:08
@ncoghlan ncoghlan merged commit 6439136 into python:3.13 Oct 8, 2024
39 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tests Tests in the Lib/test dir
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant