-
-
Notifications
You must be signed in to change notification settings - Fork 30.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-124928: Emscripten node support: Clean up old node <= 16 flags #124929
base: main
Are you sure you want to change the base?
Conversation
These flags are only needed for node <= 16. Node 16 has been end of life since October of 2023.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, can we add some assertion to check that user is using Node > 16?
Yeah that makes sense I will do that. |
Okay now it prints the following complaint to standard error and exits with code 1 on old node versions.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please also add NEWS.d that now CPython requires Node >= 18 for Emscripten build :)
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @hoodmane for cleaning up the old node stuff. Much appreciated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code changes look good; as noted elsewhere, a news entry is definitely required (the devguide has details on how to generate one).
I'll also hold off merging until python/steering-council#256 is resolved.
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase And if you don't make the requested changes, you will be poked with soft cushions! |
These flags are only needed for node <= 16. Node 16 has been end of life since
October of 2023.