Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-124613: Don't run perf tests in JIT builds #124792

Merged
merged 2 commits into from
Sep 30, 2024
Merged

gh-124613: Don't run perf tests in JIT builds #124792

merged 2 commits into from
Sep 30, 2024

Conversation

pablogsal
Copy link
Member

@pablogsal pablogsal commented Sep 30, 2024 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Sep 30, 2024
Closed
@pablogsal
pythongh-124613: Don't run perf tests in JIT builds
3e7ccf0 
Signed-off-by: Pablo Galindo <pablogsal@gmail.com>
vstinner
vstinner approved these changes Sep 30, 2024
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I just suggested some minor changes.

Lib/test/test_perf_profiler.py Outdated Show resolved Hide resolved
Lib/test/test_perf_profiler.py Outdated Show resolved Hide resolved
@pablogsal @vstinner
Apply suggestions from code review
851f12c 
Co-authored-by: Victor Stinner <vstinner@python.org>
@pablogsal pablogsal enabled auto-merge (squash) September 30, 2024 17:30
@pablogsal pablogsal added the needs backport to 3.13 bugs and security fixes label Sep 30, 2024
@pablogsal pablogsal merged commit 35541c4 into python:main Sep 30, 2024
34 checks passed
@pablogsal pablogsal deleted the gh-124613 branch September 30, 2024 17:57
@miss-islington-app
Copy link

Thanks @pablogsal for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Sorry, @pablogsal, I could not cleanly backport this to 3.13 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker 35541c410d894d4fa18002f7fdbebfe522f8320e 3.13

@brandtbucher
Copy link
Member

If we don't want to skip these on most builds, we could decorate the tests with test.support.without_optimizer. See #124794 (comment).

pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Oct 1, 2024
Revert "pythongh-124613: Don't run perf tests in JIT builds (python#1…
ad2155f 
…24792)"

This reverts commit 35541c4.
pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Oct 1, 2024
Revert "pythongh-124613: Don't run perf tests in JIT builds (python#1…
c468736 
…24792)"

This reverts commit 35541c4.
pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Oct 1, 2024
Revert "pythongh-124613: Don't run perf tests in JIT builds (python#1…
ced869b 
…24792)"

This reverts commit 35541c4.
pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Oct 1, 2024
Revert "pythongh-124613: Don't run perf tests in JIT builds (python#1…
7b082c9 
…24792)"

This reverts commit 35541c4.
pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Oct 1, 2024
Revert "pythongh-124613: Don't run perf tests in JIT builds (python#1…
81f2b81 
…24792)"

This reverts commit 35541c4.
pablogsal pushed a commit to pablogsal/cpython that referenced this pull request Oct 1, 2024
Revert "pythongh-124613: Don't run perf tests in JIT builds (python#1…
857eaed 
…24792)"

This reverts commit 35541c4.
@pablogsal pablogsal mentioned this pull request Oct 1, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@lysnikolaou lysnikolaou Awaiting requested review from lysnikolaou

@ambv ambv Awaiting requested review from ambv

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland

@corona10 corona10 Awaiting requested review from corona10

Assignees

@pablogsal pablogsal

Labels
needs backport to 3.13 bugs and security fixes skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pablogsal @brandtbucher @vstinner