Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docs: Drop letter PDF #123912

Merged
merged 1 commit into from
Sep 12, 2024
Merged

Docs: Drop letter PDF #123912

merged 1 commit into from
Sep 12, 2024

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Sep 10, 2024 •
edited by github-actions bot
Loading

Next step for python/docs-community#128.

Instead of building both A4 and letter PDFs, only build A4. This will significantly reduce the docs build times.

📚 Documentation preview 📚: https://cpython-previews--123912.org.readthedocs.build/

@hugovk hugovk added docs Documentation in the Doc dir skip issue skip news labels Sep 10, 2024
@hugovk
Copy link
Member Author

hugovk commented Sep 10, 2024

I left these bits of the Makefile so it's still possible to generate a letter PDF if you want, but perhaps we should clean them up too?

cpython/Doc/Makefile

Line 13 in a2d0818

PAPER =

cpython/Doc/Makefile

Lines 19 to 21 in a2d0818

# Internal variables.
PAPEROPT_a4 = -D latex_elements.papersize=a4paper
PAPEROPT_letter = -D latex_elements.papersize=letterpaper

cpython/Doc/Makefile

Line 26 in a2d0818

$(PAPEROPT_$(PAPER)) \

cpython/Doc/Makefile

Line 40 in a2d0818

@echo " latex to make LaTeX files, you can set PAPER=a4 or PAPER=letter"

@hugovk hugovk mentioned this pull request Sep 10, 2024
Closed
willingc
willingc approved these changes Sep 10, 2024
View reviewed changes
Copy link
Contributor

@willingc willingc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @hugovk. 🚢

@willingc
Copy link
Contributor

@hugovk I think leaving in the Makefile is fine for now.

@hugovk hugovk merged commit f5597db into python:main Sep 12, 2024
30 checks passed
@hugovk hugovk deleted the rm-letter-pdf branch September 12, 2024 10:49
@hugovk hugovk added awaiting merge needs backport to 3.12 bug and security fixes needs backport to 3.13 bugs and security fixes labels Sep 12, 2024
@miss-islington-app
Copy link

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.13.
🐍🍒⛏🤖

@miss-islington-app
Copy link

Thanks @hugovk for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2024
@hugovk @miss-islington
Docs: Drop letter PDF (pythonGH-123912)
a894e3b 
(cherry picked from commit f5597db)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app
Copy link

bedevere-app bot commented Sep 12, 2024

GH-123998 is a backport of this pull request to the 3.13 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Sep 12, 2024
@hugovk @miss-islington
Docs: Drop letter PDF (pythonGH-123912)
057d926 
(cherry picked from commit f5597db)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Sep 12, 2024
@bedevere-app
Copy link

bedevere-app bot commented Sep 12, 2024

GH-123999 is a backport of this pull request to the 3.12 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.12 bug and security fixes label Sep 12, 2024
hugovk added a commit that referenced this pull request Sep 16, 2024
@miss-islington @hugovk
[3.12] Docs: Drop letter PDF (GH-123912) (#123999)
f3c1f3d 
Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Yhg1s pushed a commit that referenced this pull request Sep 23, 2024
@miss-islington @hugovk
[3.13] Docs: Drop letter PDF (GH-123912) (#123998)
355dc72 
Docs: Drop letter PDF (GH-123912)
(cherry picked from commit f5597db)

Co-authored-by: Hugo van Kemenade <1324225+hugovk@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@willingc willingc willingc approved these changes

Assignees
No one assigned
Labels
awaiting merge docs Documentation in the Doc dir skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hugovk @willingc