Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-110109: pathlib ABCs: drop use of io.text_encoding() #113417

Merged
merged 2 commits into from
Dec 27, 2023
Merged

GH-110109: pathlib ABCs: drop use of io.text_encoding() #113417

merged 2 commits into from
Dec 27, 2023

Conversation

barneygale
Copy link
Contributor

@barneygale barneygale commented Dec 22, 2023 •
edited by bedevere-app bot
Loading

Do not use the locale-specific default encoding in PathBase.read_text() and write_text(). Locale settings shouldn't influence the operation of these base classes, which are intended mostly for implementing rich paths on nonlocal filesystems.

Also add a comment explaining the necessity of the io.text_encoding() call in Path.read_text() and write_text() despite its presence in open().

@barneygale
pythonGH-110109: pathlib ABCs: drop use of io.text_encoding()
b3a7c27 
Do not use the locale-specific default encoding in `PathBase.read_text()`
and `write_text()`. Locale settings shouldn't influence the operation of
these base classes, which are intended mostly for implementing rich paths
on *nonlocal* filesystems.
@bedevere-app bedevere-app bot mentioned this pull request Dec 22, 2023
Closed
8 tasks
@barneygale
Copy link
Contributor Author

Downstream pathlib_abc issue: barneygale/pathlib-abc#12

@barneygale
Copy link
Contributor Author

Thank you for the review, @methane

@barneygale barneygale merged commit f8b6e17 into python:main Dec 27, 2023
29 checks passed
kulikjak pushed a commit to kulikjak/cpython that referenced this pull request Jan 22, 2024
@barneygale @kulikjak
pythonGH-110109: pathlib ABCs: drop use of io.text_encoding() (pyth…
de5e342 
…on#113417)

Do not use the locale-specific default encoding in `PathBase.read_text()`
and `write_text()`. Locale settings shouldn't influence the operation of
these base classes, which are intended mostly for implementing rich paths
on *nonlocal* filesystems.
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
@barneygale @aisk
pythonGH-110109: pathlib ABCs: drop use of io.text_encoding() (pyth…
b08ec58 
…on#113417)

Do not use the locale-specific default encoding in `PathBase.read_text()`
and `write_text()`. Locale settings shouldn't influence the operation of
these base classes, which are intended mostly for implementing rich paths
on *nonlocal* filesystems.
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
@barneygale @Glyphack
pythonGH-110109: pathlib ABCs: drop use of io.text_encoding() (pyth…
20dffcf 
…on#113417)

Do not use the locale-specific default encoding in `PathBase.read_text()`
and `write_text()`. Locale settings shouldn't influence the operation of
these base classes, which are intended mostly for implementing rich paths
on *nonlocal* filesystems.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@methane methane methane approved these changes

Assignees
No one assigned
Labels
skip news topic-pathlib
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@barneygale @methane