gh-61648: Detect line numbers of properties in doctests #113161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
serhiy-storchaka
commented
Dec 15, 2023
•
serhiy-storchaka
commented
- Issue: doctest test finder doesnt find line numbers of properties #61648
serhiy-storchaka
added
needs backport to 3.11
AlexWaygood
approved these changes
Dec 15, 2023
There was a problem hiding this comment.
LGTM. Two thoughts, both of which are beyond the scope of this PR:
- It's a shame
doctestdoesn't have more generalised support for other kinds of descriptors;functools.cached_propertydoctests will still not have line numbers, for example. But it is much harder to do without changingdoctest's whole approach, I know. - I'm curious if the
_find_linenofunction correctly handles wrapped functions (e.g. those returned fromfunctools.wraps). Even if it works correctly now, it would be good to add tests for this. But again, it is a separate issue that should be tackled separately.
|
Thanks @serhiy-storchaka for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
|
GH-113164 is a backport of this pull request to the 3.12 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 15, 2023
…GH-113161) (cherry picked from commit 8f8f0f9) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Dec 15, 2023
…GH-113161) (cherry picked from commit 8f8f0f9) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-113165 is a backport of this pull request to the 3.11 branch. |
serhiy-storchaka
added a commit
that referenced
this pull request
Dec 15, 2023
serhiy-storchaka
added a commit
that referenced
this pull request
Dec 15, 2023
corona10
pushed a commit
to corona10/cpython
that referenced
this pull request
Dec 15, 2023
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.