Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-111213: Fix a few broken stats #111216

Merged
merged 1 commit into from
Oct 26, 2023
Merged

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Oct 23, 2023

@mdboom Do you want to merge #110398 first?

@mdboom
Copy link
Contributor

mdboom commented Oct 23, 2023

@mdboom Do you want to merge #110398 first?

Yes, that makes sense, but you'll have to take the honor, @markshannon (I don't have merge privs).

@mdboom
Copy link
Contributor

mdboom commented Oct 23, 2023

Let's merge #110398 and then I can do the non-trivial port of this on top of that.

Copy link
Contributor

@mdboom mdboom left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. The summarize_stats.py changes won't cleanly apply after #110398, but I can take on adapting this to the new way.

@mdboom
Copy link
Contributor

mdboom commented Oct 24, 2023

@markshannon: I updated this branch so it works on top of the summarize_stats.py refactor. It's up to you to approve and merge now, I think.

@markshannon markshannon merged commit b0699aa into python:main Oct 26, 2023
25 checks passed
@markshannon markshannon deleted the fix-stats branch October 26, 2023 10:33
aisk pushed a commit to aisk/cpython that referenced this pull request Feb 11, 2024
Glyphack pushed a commit to Glyphack/cpython that referenced this pull request Sep 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants