Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gh-106368: Increase test coverage for Argument Clinic #107514

Merged
merged 6 commits into from
Aug 2, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 31, 2023

@erlend-aasland
Copy link
Contributor Author

With this, we're pretty good covered (above 90%). AFAICS, converters, return converters, and most parser code has been tested. Most of what's missing is various error paths.

I suggest we close the linked issue after landing this.

Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! 👍

Lib/test/clinic.test.c Outdated Show resolved Hide resolved
Lib/test/test_clinic.py Outdated Show resolved Hide resolved
@erlend-aasland

This comment was marked as outdated.

Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The .py tests LGTM! Nikita's almost certainly a better reviewer for the functional tests :)

@erlend-aasland erlend-aasland linked an issue Aug 2, 2023 that may be closed by this pull request
@erlend-aasland
Copy link
Contributor Author

The .py tests LGTM! Nikita's almost certainly a better reviewer for the functional tests :)

Thanks for the review; Nikita gave a thumbs up for the functional tests earlier, so I'll enable auto-merge 🚀

@erlend-aasland erlend-aasland enabled auto-merge (squash) August 2, 2023 12:50
@erlend-aasland erlend-aasland merged commit b9c9a36 into python:main Aug 2, 2023
17 checks passed
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b9c9a36c2f2edc11b9c27eb7c5810919d9da9767 3.12

@miss-islington
Copy link
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b9c9a36c2f2edc11b9c27eb7c5810919d9da9767 3.11

@erlend-aasland erlend-aasland deleted the clinic/coverage branch August 2, 2023 13:36
@picnixz
Copy link
Contributor

picnixz commented Sep 14, 2024

3.11 and 3.12 never got their backports but I'm removing the labels (I'm going through PRs to see if we did not forgot a backport) (not sure if you want to backport this on 3.12)

@picnixz picnixz removed needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Sep 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase Argument Clinic test coverage
6 participants