Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-106368: Increase Argument Clinic test coverage #106728

Merged
merged 3 commits into from
Jul 13, 2023
Merged

gh-106368: Increase Argument Clinic test coverage #106728

merged 3 commits into from
Jul 13, 2023

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jul 13, 2023 •
edited
Loading

  • improve output_parameter() coverage
  • improve coverage for Function.kind

@bedevere-bot bedevere-bot mentioned this pull request Jul 4, 2023
Closed
@erlend-aasland erlend-aasland added needs backport to 3.11 only security fixes needs backport to 3.12 bug and security fixes labels Jul 13, 2023
@AlexWaygood
Copy link
Member

I'm probably not the best reviewer for this one, but this all looks reasonable!

@erlend-aasland
Copy link
Contributor Author

I'm probably not the best reviewer for this one, but this all looks reasonable!

Thanks! I'll expand this PR so we've got better coverage for your FunctionKind PR.

@erlend-aasland erlend-aasland changed the title gh-106368: Argument Clinic: Increase coverage for output_parameters() gh-106368: Increase Argument Clinic test coverage Jul 13, 2023
@erlend-aasland
Copy link
Contributor Author

With this, we're up to approx. 86% test coverage.

@erlend-aasland erlend-aasland enabled auto-merge (squash) July 13, 2023 22:17
@erlend-aasland erlend-aasland merged commit ec45c51 into python:main Jul 13, 2023
14 checks passed
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry, @erlend-aasland, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker ec45c513d389510930a62631a21a1dbb3f3aabb7 3.11

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 13, 2023
@erlend-aasland @miss-islington
pythongh-106368: Increase Argument Clinic test coverage (pythonGH-106728
604c2ce 
)

- improve output_parameter() coverage
- improve coverage for Function.kind
(cherry picked from commit ec45c51)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-bot
Copy link

GH-106730 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 bug and security fixes label Jul 13, 2023
@erlend-aasland erlend-aasland deleted the clinic/coverage-defining-class-alt branch July 13, 2023 22:19
@bedevere-bot
Copy link

GH-106731 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jul 13, 2023
erlend-aasland added a commit that referenced this pull request Jul 13, 2023
@miss-islington @erlend-aasland
[3.12] gh-106368: Increase Argument Clinic test coverage (GH-106728) (#…
6a1a660 
…106730)

- improve output_parameter() coverage
- improve coverage for Function.kind
(cherry picked from commit ec45c51)

Co-authored-by: Erlend E. Aasland <erlend@python.org>
@bedevere-bot

This comment was marked as off-topic.

Sign in to view
erlend-aasland added a commit that referenced this pull request Jul 13, 2023
@erlend-aasland
[3.11] gh-106368: Increase Argument Clinic test coverage (#106728) (#…
d22224a 
…106731)

- improve output_parameter() coverage
- improve coverage for Function.kind

(cherry picked from commit ec45c51)

Co-authored-by: Erlend E. Aasland <erlend@python.org>

* Fix merge
@bedevere-bot

This comment was marked as off-topic.

Sign in to view
kgdiem pushed a commit to kgdiem/cpython that referenced this pull request Jul 14, 2023
@erlend-aasland @kgdiem
pythongh-106368: Increase Argument Clinic test coverage (python#106728)
9acddfa 
- improve output_parameter() coverage
- improve coverage for Function.kind
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood Awaiting requested review from AlexWaygood

Assignees

@erlend-aasland erlend-aasland

Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@erlend-aasland @AlexWaygood @miss-islington @bedevere-bot