Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[3.8] gh-102153: Start stripping C0 control and space chars in `urlsp… #104918

Closed
wants to merge 2 commits into from
Closed

[3.8] gh-102153: Start stripping C0 control and space chars in `urlsp… #104918

wants to merge 2 commits into from

Commits on May 25, 2023

  1. [3.8] pythongh-102153: Start stripping C0 control and space chars in … 

    …`urlsplit`

pythongh-102153: Start stripping C0 control and space chars in `urlsplit` (pythonGH-102508)

`urllib.parse.urlsplit` has already been respecting the WHATWG spec a bit pythonGH-25595.

This adds more sanitizing to respect the "Remove any leading C0 control or space from input" [rule](https://url.spec.whatwg.org/GH-url-parsing:~:text=Remove%20any%20leading%20and%20trailing%20C0%20control%20or%20space%20from%20input.) in response to [CVE-2023-24329](https://nvd.nist.gov/vuln/detail/CVE-2023-24329).

I simplified the docs by eliding the state of the world explanatory
paragraph in this security release only backport.  (people will see
that in the mainline /3/ docs)

Co-authored-by: Illia Volochii <illia.volochii@gmail.com>
Co-authored-by: Gregory P. Smith [Google] <greg@krypto.org>
Co-authored-by: Enji Cooper <yaneurabeya@gmail.com>
    @ngie-eign @illia-v @gpshead
    3 people committed May 25, 2023
    Configuration menu
    Copy the full SHA
    737be53 View commit details
    Browse the repository at this point in the history

  2. 📜🤖 Added by blurb_it.

    @blurb-it
    blurb-it[bot] authored May 25, 2023
    Configuration menu
    Copy the full SHA
    f39f666 View commit details
    Browse the repository at this point in the history