gh-103968: Deprecate creating heap types whose metaclass has custom tp_new. #103972
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…stom tp_new. (That's a mouthful of an edge case!)
barneygale
reviewed
Apr 29, 2023
Comment on lines
+262
to
+265
| (For backwards compatibility, other ``PyType_From*`` functions allow | ||
| such metaclasses. They ignore ``tp_new``, which may result in incomplete | ||
| initialization. This is deprecated and in Python 3.14+ such metaclasses will | ||
| not be supported.) |
There was a problem hiding this comment.
This could be nested in a .. deprecated:: 3.12 block I suppose? And below.
There was a problem hiding this comment.
It's mentioned in .. versionchanged:: 3.12 in the affected functions.
Their docs are just Equivalent to ``PyType_FromMetaclass(NULL, NULL, arg, NULL, NULL)`` and a bunch of change notes, so the PyType_FromMetaclass docs need this parenthetical to be complete.
Co-authored-by: Barney Gale <barney.gale@gmail.com>
erlend-aasland
approved these changes
May 3, 2023
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(That's a mouthful of an edge case!)