Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-63062: Implement __subclasshook__() for Finders and Loaders in abc lib #102763

Closed
wants to merge 4 commits into from
Closed

GH-63062: Implement __subclasshook__() for Finders and Loaders in abc lib #102763

wants to merge 4 commits into from

Conversation

furkanonder
Copy link
Contributor

@furkanonder furkanonder commented Mar 16, 2023 •
edited by bedevere-bot
Loading

@bedevere-bot bedevere-bot mentioned this pull request Mar 16, 2023
Open
@brettcannon
Copy link
Member

FYI there's a merge conflict.

@brettcannon brettcannon removed their request for review June 9, 2023 22:29
@brettcannon
Copy link
Member

To keep my review queue clean, I'm removing myself to review until the merge conflict is fixed. Feel free to add me back once the conflict is fixed.

@furkanonder
Copy link
Contributor Author

This PR seems to deprecate find_loader and find_module. For this reason I think it makes sense to close the PR. @brettcannon What do you think?

@brettcannon
Copy link
Member

@furkanonder it's your PR so if you think it should be closed I'm fine with that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

@brettcannon brettcannon Awaiting requested review from brettcannon brettcannon is a code owner

@ncoghlan ncoghlan Awaiting requested review from ncoghlan ncoghlan is a code owner

@warsaw warsaw Awaiting requested review from warsaw warsaw is a code owner

Assignees
No one assigned
Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@furkanonder @brettcannon @bedevere-bot