Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-102690: Use Edge as fallback in webbrowser instead of IE #102691

Merged
merged 9 commits into from
Mar 16, 2023
Merged

gh-102690: Use Edge as fallback in webbrowser instead of IE #102691

Show file tree
Hide file tree
Changes from 5 commits
Commits
Show all changes
9 commits
Select commit Hold shift + click to select a range
c33c859
Update webbrowser.py to use Edge as fallback instead of IE
DBJim Mar 14, 2023
f82848d
Merge branch 'main' into main
DBJim Mar 14, 2023
3b4d8dd
📜🤖 Added by blurb_it.
blurb-it[bot] Mar 14, 2023
ecc53fb
Update Lib/webbrowser.py
DBJim Mar 14, 2023
8a00dec
Update Misc/NEWS.d/next/Windows/2023-03-14-10-52-43.gh-issue-102690.s…
DBJim Mar 14, 2023
b91f873
Merge branch 'python:main' into main
DBJim Mar 15, 2023
55ec113
Update variable names, add descriptive comments
DBJim Mar 15, 2023
3fd510f
style
merwok Mar 15, 2023
3c42f6d
Update Lib/webbrowser.py
DBJim Mar 16, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 6 additions & 4 deletions Lib/webbrowser.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -542,11 +542,13 @@ def register_standard_browsers():
# First try to use the default Windows browser
register("windows-default", WindowsDefault)

# Detect some common Windows browsers, fallback to IE
iexplore = os.path.join(os.environ.get("PROGRAMFILES", "C:\\Program Files"),
"Internet Explorer\\IEXPLORE.EXE")
# Detect some common Windows browsers, fallback to Edge
edge = os.path.join(os.environ.get("PROGRAMFILES(x86)", "C:\\Program Files (x86)"),
"Microsoft\\Edge\\Application\\msedge.exe")
edge32 = os.path.join(os.environ.get("PROGRAMFILES", "C:\\Program Files"),
zooba marked this conversation as resolved.
Show resolved Hide resolved
"Microsoft\\Edge\\Application\\msedge.exe")
DBJim marked this conversation as resolved.
Show resolved Hide resolved
for browser in ("firefox", "firebird", "seamonkey", "mozilla",
"netscape", "opera", iexplore):
"opera", edge, edge32):
if shutil.which(browser):
register(browser, None, BackgroundBrowser(browser))
else:
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Windows/2023-03-14-10-52-43.gh-issue-102690.sbXtqk.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Update :mod:`webbrowser` to fall back to Microsoft Edge instead of Internet Explorer.