Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-99108: Followup fix for Modules/Setup #102183

Merged
merged 1 commit into from
Feb 23, 2023
Merged

gh-99108: Followup fix for Modules/Setup #102183

merged 1 commit into from
Feb 23, 2023

Conversation

msprotz
Copy link
Contributor

@msprotz msprotz commented Feb 23, 2023 •
edited by erlend-aasland
Loading

Automerge-Triggered-By: GH:erlend-aasland

@bedevere-bot bedevere-bot mentioned this pull request Feb 23, 2023
Open
@msprotz msprotz mentioned this pull request Feb 23, 2023
Merged
asottile
asottile approved these changes Feb 23, 2023
View reviewed changes
Copy link
Contributor

@asottile asottile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no idea why the cpython suite doesn't fail -- my guess is it doesn't use this file

@msprotz
Copy link
Contributor Author

msprotz commented Feb 23, 2023

thanks -- do you mind adding a skip-news label, too?

@erlend-aasland
Copy link
Contributor

erlend-aasland commented Feb 23, 2023 •
edited
Loading

Can you please fix Modules/Setup.stdlib.in also?

@asottile
Copy link
Contributor

Can you please fix Modules/Setup.stdlib.in also?

afaict that file is correct (and validated because it gets used by the testsuite)

@miss-islington
Copy link
Contributor

Status check is done, and it's a success ✅.

@miss-islington miss-islington merged commit d43c265 into python:main Feb 23, 2023
@gpshead
Copy link
Member

gpshead commented Feb 23, 2023

I personally don't know why Modules/Setup even exists anymore, I thought the .in file template replaced it.

@msprotz msprotz deleted the protz_md5_sha1 branch February 23, 2023 22:49
@erlend-aasland
Copy link
Contributor

I personally don't know why Modules/Setup even exists anymore, I thought the .in file template replaced it.

Yes, true. I'm not sure if Modules/Setup is actually usable. If it is unusable, we should just tear it out.

JelleZijlstra pushed a commit to JelleZijlstra/cpython that referenced this pull request Sep 10, 2024
@msprotz @JelleZijlstra
pythongh-99108: Followup fix for Modules/Setup (pythonGH-102183)
02473a9 
Automerge-Triggered-By: GH:erlend-aasland
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asottile asottile asottile approved these changes

@erlend-aasland erlend-aasland erlend-aasland approved these changes

@tiran tiran Awaiting requested review from tiran

@corona10 corona10 Awaiting requested review from corona10

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@msprotz @erlend-aasland @asottile @miss-islington @gpshead @zware @bedevere-bot