Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doctest: Pin sphinxext-opengraph==0.7.5 to prevent importing NumPy #101642

Merged
merged 1 commit into from
Feb 7, 2023

Conversation

hugovk
Copy link
Member

@hugovk hugovk commented Feb 7, 2023

We use a Sphinx extension to help with SEO metadata. They recently added (in 0.8.0) support for generating images for social media cards (wpilibsuite/sphinxext-opengraph#88). We're not using that feature, but it still attempts to install and import Matplotlib and its dependency NumPy, which can fail the doctest for 3.12/main due to incompatibilities.

For now, let's pin to the previous version, sphinxext-opengraph==0.7.5, and make another fix later (see: #101639 (comment)).

@hugovk hugovk changed the title Doctest: Pin sphinxext-opengraph==0.7.9 to prevent importing NumPy Doctest: Pin sphinxext-opengraph==0.7.5 to prevent importing NumPy Feb 7, 2023
@ambv ambv merged commit a757d72 into python:main Feb 7, 2023
@miss-islington
Copy link
Contributor

Thanks @hugovk for the PR, and @ambv for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry @hugovk and @ambv, I had trouble checking out the 3.11 backport branch.
Please retry by removing and re-adding the "needs backport to 3.11" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker a757d721271974c45e2feacef739af4e86ec7350 3.11

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants