Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101283: Try to load the fallback cmd.exe by an absolute path #101286

Merged
merged 25 commits into from
Feb 8, 2023
Merged

gh-101283: Try to load the fallback cmd.exe by an absolute path #101286

merged 25 commits into from
Feb 8, 2023
+58 −1

Commits on Jan 24, 2023

  1. Try to load the fallback cmd.exe by an absolute path

    @arhadthedev
    arhadthedev committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    d122f14 View commit details
    Browse the repository at this point in the history

  2. Add a NEWS entry

    @arhadthedev
    arhadthedev committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    e96457c View commit details
    Browse the repository at this point in the history

  3. Fix minor grammar

    @arhadthedev
    arhadthedev committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    b26918e View commit details
    Browse the repository at this point in the history

  4. Address patchcheck CI error report

    @arhadthedev
    arhadthedev committed Jan 24, 2023
    Configuration menu
    Copy the full SHA
    9a0fdbd View commit details
    Browse the repository at this point in the history

  5. Address the review 

    Co-authored-by: Eryk Sun <eryksun@gmail.com>
    @arhadthedev @eryksun
    arhadthedev and eryksun authored Jan 24, 2023
    Configuration menu
    Copy the full SHA
    091e970 View commit details
    Browse the repository at this point in the history

  6. Simplify NEWS wording and reattribute the totally rewritten PR

    @arhadthedev
    arhadthedev authored Jan 24, 2023
    Configuration menu
    Copy the full SHA
    a3cbdb6 View commit details
    Browse the repository at this point in the history

  7. Address the review-2 

    Co-authored-by: Eryk Sun <eryksun@gmail.com>
    @arhadthedev @eryksun
    arhadthedev and eryksun authored Jan 24, 2023
    Configuration menu
    Copy the full SHA
    8dab7f1 View commit details
    Browse the repository at this point in the history

  8. Update Lib/subprocess.py 

    Co-authored-by: Eryk Sun <eryksun@gmail.com>
    @arhadthedev @eryksun
    arhadthedev and eryksun authored Jan 24, 2023
    Configuration menu
    Copy the full SHA
    1d8d4a6 View commit details
    Browse the repository at this point in the history

Commits on Jan 25, 2023

  1. Simplify the NEWS entry

    @arhadthedev
    arhadthedev committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    9ed1758 View commit details
    Browse the repository at this point in the history

  2. Clarify attribution

    @arhadthedev
    arhadthedev committed Jan 25, 2023
    Configuration menu
    Copy the full SHA
    a2734a6 View commit details
    Browse the repository at this point in the history

  3. Update 2023-01-24-16-12-00.gh-issue-101283.9tqu39.rst

    @arhadthedev
    arhadthedev authored Jan 25, 2023
    Configuration menu
    Copy the full SHA
    407aa35 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2023

  1. Merge branch 'main' into absolute-cmdexe-fallback-patch

    @arhadthedev
    arhadthedev committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    f1dfcff View commit details
    Browse the repository at this point in the history

  2. Add Changed in version entries

    @arhadthedev
    arhadthedev committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    880d443 View commit details
    Browse the repository at this point in the history

  3. Try another multiversion syntax

    @arhadthedev
    arhadthedev committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    b34f998 View commit details
    Browse the repository at this point in the history

  4. Try the third, multiline syntax

    @arhadthedev
    arhadthedev committed Jan 28, 2023
    Configuration menu
    Copy the full SHA
    84cf94f View commit details
    Browse the repository at this point in the history

Commits on Jan 30, 2023

  1. Apply the gpshead's suggestion

    @arhadthedev
    arhadthedev committed Jan 30, 2023
    Configuration menu
    Copy the full SHA
    9cbdfca View commit details
    Browse the repository at this point in the history

Commits on Jan 31, 2023

  1. Merge branch 'main' into absolute-cmdexe-fallback-patch

    @arhadthedev
    arhadthedev authored Jan 31, 2023
    Configuration menu
    Copy the full SHA
    8bfb11b View commit details
    Browse the repository at this point in the history

Commits on Feb 8, 2023

  1. Address the review

    @arhadthedev
    arhadthedev authored Feb 8, 2023
    Configuration menu
    Copy the full SHA
    86473da View commit details
    Browse the repository at this point in the history

  2. Apply suggestions from code review 

    Co-authored-by: Steve Dower <steve.dower@microsoft.com>
    @arhadthedev @zooba
    arhadthedev and zooba authored Feb 8, 2023
    Configuration menu
    Copy the full SHA
    f1b4412 View commit details
    Browse the repository at this point in the history

  3. Improve performance by triggering cmd.exe search on `executable=Non… 

    …e` only
    @arhadthedev
    arhadthedev authored Feb 8, 2023
    Configuration menu
    Copy the full SHA
    11ebd69 View commit details
    Browse the repository at this point in the history

  4. Update the Changed In section

    @arhadthedev
    arhadthedev authored Feb 8, 2023
    Configuration menu
    Copy the full SHA
    25dcbb8 View commit details
    Browse the repository at this point in the history

  5. Update Lib/subprocess.py 

    Co-authored-by: Eryk Sun <eryksun@gmail.com>
    @arhadthedev @eryksun
    arhadthedev and eryksun authored Feb 8, 2023
    Configuration menu
    Copy the full SHA
    fc08548 View commit details
    Browse the repository at this point in the history

  6. Fix env variable name misquoting

    @arhadthedev
    arhadthedev authored Feb 8, 2023
    Configuration menu
    Copy the full SHA
    7e06703 View commit details
    Browse the repository at this point in the history

  7. Manually fix env variable name misquoting

    @arhadthedev
    arhadthedev committed Feb 8, 2023
    Configuration menu
    Copy the full SHA
    81aba86 View commit details
    Browse the repository at this point in the history

  8. Update Lib/subprocess.py 

    Co-authored-by: Steve Dower <steve.dower@microsoft.com>
    @arhadthedev @zooba
    arhadthedev and zooba authored Feb 8, 2023
    Configuration menu
    Copy the full SHA
    fecd606 View commit details
    Browse the repository at this point in the history